From owner-svn-src-all@freebsd.org Sat Dec 16 03:54:20 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 005C2E9AD0A for ; Sat, 16 Dec 2017 03:54:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B6BB1751E7 for ; Sat, 16 Dec 2017 03:54:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22f.google.com with SMTP id 68so22223636ite.4 for ; Fri, 15 Dec 2017 19:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=r2uhZ6Of0iA9HAedVy2zDfy3f49WhijJslFkU7LD558=; b=1gloXoY3e6Z4Zh8x0KYm7jMu3Isn0Ywwh3OPPugWZRK5dV8iGv0zosKW4fRpxU8EFO cjuOrqcpqGwOzvPYr2SiwiM9wK/+WZA2QUGAhB2k76k7WRA0NK2nD+1j2ezeFEd1KEnk RkJlZ9FvQXL3PGXUHAchKINwP6jcnLKw5feCOQa+N7zkRwiEoNRRFpGPWB7aSezeqAiW oXcsO1GgKoRB5uvqehQ6XZGsUG/LgrFeRICc62n0Y27P8MYa9vKRtzLaReSYZnH+kfSe fnNSEXpfXy//qGtyZqd4VKPlnp3aEvKwLldQI3wkrs9utjmuVb/kwA8p5hVirPWE1uz2 ETew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=r2uhZ6Of0iA9HAedVy2zDfy3f49WhijJslFkU7LD558=; b=i+pvKUgBFGg7FQbhbQ1NBeODZPNsAcGGnMsHy+0R3xmiOgmA6C0QPjYOa48I8Ufh5b ql5dUodpFEJ1gtd4xGYQt7a15Hpl/7SQqPGkJu3QrCP4t7LJfbUWhXQNuprpvNawCBWS wTvNCBeQDPi12hVya31ZpqK60jI+qMvD6Pt1rX3G7rAYNxxV0oj9gjw8UbzpWQcg4JSx G35te4hBCmzTybsqSr/63ihuoE2PNAtmHjpbiohS95djBJy35da+Ba4kuVc0vjhtXBtj 7fq5HYwPVZIMuj6V7UPCdqPc2Yjb/afAAqPwST6EXFnJAmLkqUi77C0lT+9/7Lj/kEOz ik/w== X-Gm-Message-State: AKGB3mJqpM1njOLEUDcsrZwVjBxjwqZaYVgt933GoecrWiso5t5NP3/U I+t+cp2njMoruScAUCfncB5UltRG5+IK2OyCuzzCyA== X-Google-Smtp-Source: ACJfBouBs/Thi6Yp5ibdVJ7VqGdEfC2UQ8Ob13zgcyHvjoOImH5ND3RdzFJS2CYpRS3Ct4E5StzW+4jla9bROcdc2fU= X-Received: by 10.36.77.143 with SMTP id l137mr11650194itb.50.1513396458853; Fri, 15 Dec 2017 19:54:18 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Fri, 15 Dec 2017 19:54:18 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201712160339.vBG3djMr005140@pdx.rh.CN85.dnsmgr.net> References: <201712152316.vBFNGRZ4041100@repo.freebsd.org> <201712160339.vBG3djMr005140@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Fri, 15 Dec 2017 20:54:18 -0700 X-Google-Sender-Auth: 171KuEfSK4SVUirjruYn-kmCyqA Message-ID: Subject: Re: svn commit: r326883 - head/tools/boot To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Dec 2017 03:54:20 -0000 On Fri, Dec 15, 2017 at 8:39 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: imp > > Date: Fri Dec 15 23:16:27 2017 > > New Revision: 326883 > > URL: https://svnweb.freebsd.org/changeset/base/326883 > > > > Log: > > For now, make the gpart commands verbose so we know exactly what's > > being installed. > > > > Fix problem with gpt + zfs installing the wrong loader... > ... > > Would it make since to get the svn version in at least the > major parts of this code so that one can tell what is installed > easier? Ie, the parts of zfsboot you dd into the reserved space, > boot1, loader.efi, etc. > I've often desired this. There's some practical issues around doing something specific, however. We don't want to create a new binary that differs only by the build date from the old one. For reproducible builds, we try to make binaries that don't have any marking like this. > I know that for the MBR it probably makes little since, but for > boot1 and later we shouldnt be so tight on room we can not put > in a short character string? > I like this idea. boot0/boot1/boot2 for MBR and the boot1 part of zfsboot are quite limited in space. The others have acres of space, and are likely to have that space for the foreseeable future. We do this today for /boot/*loader* already, though we don't have a simple way to retrieve things. There's also a version number that's printed, but that's ill maintained. We may be able to leverage the built-time stuff here somehow. I'd also like to add the compile-time boot options that's printed on boot and maybe easily retrievable. Might be easier to pass this stuff in via kenv vars and/or meta data somehow, but that only works on a booted system, not on an arbitrary device. Warner