From owner-freebsd-ipfw@FreeBSD.ORG  Mon Jul  4 05:50:09 2011
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69874106566C
	for <freebsd-ipfw@hub.freebsd.org>;
	Mon,  4 Jul 2011 05:50:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 5A2B68FC0A
	for <freebsd-ipfw@hub.freebsd.org>;
	Mon,  4 Jul 2011 05:50:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p645o9YB067281
	for <freebsd-ipfw@freefall.freebsd.org>; Mon, 4 Jul 2011 05:50:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p645o9Z2067280;
	Mon, 4 Jul 2011 05:50:09 GMT (envelope-from gnats)
Date: Mon, 4 Jul 2011 05:50:09 GMT
Message-Id: <201107040550.p645o9Z2067280@freefall.freebsd.org>
To: freebsd-ipfw@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/131817: commit references a PR
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2011 05:50:09 -0000

The following reply was made to PR kern/131817; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/131817: commit references a PR
Date: Mon,  4 Jul 2011 05:48:00 +0000 (UTC)

 Author: ae
 Date: Mon Jul  4 05:47:48 2011
 New Revision: 223753
 URL: http://svn.freebsd.org/changeset/base/223753
 
 Log:
   ARP code reuses mbuf from ARP request to make a reply, but it does not
   reset rcvif to NULL. Since rcvif is not NULL, ipfw(4) supposes that ARP
   replies were received on specified interface.
   Reset rcvif to NULL for ARP replies to fix this issue.
   
   PR:		kern/131817
   Reviewed by:	glebius
   MFC after:	1 month
 
 Modified:
   head/sys/netinet/if_ether.c
 
 Modified: head/sys/netinet/if_ether.c
 ==============================================================================
 --- head/sys/netinet/if_ether.c	Mon Jul  4 03:19:06 2011	(r223752)
 +++ head/sys/netinet/if_ether.c	Mon Jul  4 05:47:48 2011	(r223753)
 @@ -857,6 +857,7 @@ reply:
  	ah->ar_pro = htons(ETHERTYPE_IP); /* let's be sure! */
  	m->m_len = sizeof(*ah) + (2 * ah->ar_pln) + (2 * ah->ar_hln);   
  	m->m_pkthdr.len = m->m_len;   
 +	m->m_pkthdr.rcvif = NULL;
  	sa.sa_family = AF_ARP;
  	sa.sa_len = 2;
  	(*ifp->if_output)(ifp, m, &sa, NULL);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"