From owner-freebsd-hackers@freebsd.org Wed Oct 7 18:33:43 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 96FD843583B; Wed, 7 Oct 2020 18:33:43 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C62zC3V3lz3cx7; Wed, 7 Oct 2020 18:33:43 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 571D618655; Wed, 7 Oct 2020 18:33:43 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f176.google.com with SMTP id q26so2823648qtb.5; Wed, 07 Oct 2020 11:33:43 -0700 (PDT) X-Gm-Message-State: AOAM533dp7aFTky6kSexS397NyHZryPub3XifF7AWoGf9OAOA6xvTpIw ++PC5WSjVGIKEV29EaZ9UiOydumxhqx17cc5if8= X-Google-Smtp-Source: ABdhPJwkn/r+yIhIAgRQ2aVYuEgyltJPtfXreWbbVozWXy8Wu3XIWLYaPWLbrzghm1KFR/wng77A8tKhPbXoOq8fTPk= X-Received: by 2002:ac8:33e8:: with SMTP id d37mr4467446qtb.310.1602095622771; Wed, 07 Oct 2020 11:33:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kyle Evans Date: Wed, 7 Oct 2020 13:33:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Domain Patches To: freebsd-net , FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 18:33:43 -0000 On Wed, Oct 7, 2020 at 11:45 AM Kyle Evans wrote: > > Hi, > > I have a couple of domain patches in review, if anyone would like to > comment/review the area: > > https://reviews.freebsd.org/D25062 adds a dom_probe callback so that > domains can indicate whether they should be supported at all or not. > This avoids some dirty stuff in domains that may not be supported > based on the hardware that's present (e.g. hvsock included in the > review, which shouldn't be available outside of HyperV). Instead of > having to account for circumstances like that in individual callbacks, > this is a single hammer to prevent any further reach into the domain. > > D25062 also updates domain(9) to reflect some changes from the past 11 > years (splitting initialization out into domain_init, dom_destroy > addition). > > https://reviews.freebsd.org/D25459 should make it safe to add domains > after domainfinalize (i.e. they can be loadable at runtime). The big > issue with doing this previously is that pfslowtimo/pffasttimo have > already been setup and may be called on domains that aren't completely > initialized. There are some additional races re: socket creation that > should be addressed, but this review should be sufficient for at least > removing the warning. Add https://reviews.freebsd.org/D26709 to the list -- in D25459, mjg suggested adding some lists with domains or protocols that actually have {slow,fast}timo callbacks to avoid additional overhead from branching+atomics in those callbacks. Thanks, Kyle Evans