From owner-p4-projects@FreeBSD.ORG  Mon Jun 21 01:23:47 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C26011065670; Mon, 21 Jun 2010 01:23:47 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 87050106566C
	for <perforce@freebsd.org>; Mon, 21 Jun 2010 01:23:47 +0000 (UTC)
	(envelope-from julien.laffaye@gmail.com)
Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 1451F8FC08
	for <perforce@freebsd.org>; Mon, 21 Jun 2010 01:23:46 +0000 (UTC)
Received: by bwz8 with SMTP id 8so1344510bwz.13
	for <perforce@freebsd.org>; Sun, 20 Jun 2010 18:23:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:sender:received
	:in-reply-to:references:date:x-google-sender-auth:message-id:subject
	:from:to:cc:content-type:content-transfer-encoding;
	bh=huR16ND571j0VbV/EG2hTfFb06+3NHKagLdjBLe13xM=;
	b=lNMp97MHkd9/awNXdOVvuGvmNKSUhPVFUA/LCn/psQhgT6yPMir54dvqL9mYLLjA1L
	4hCEyoKQ2PyTwqfpCUQ5SuDWb1hfL2duWu/l16hkcbFcclBMaKVQi56Vl0LhedjOPwJe
	yoGd+lww5Bj+3Z64+WcegmOS4hekwqBG8j//8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	b=J0fwr9iVmnoWIuMTe/GsFl2B1e4bSqhfgXglTGajDDEbWoz4ET3qdBfYEaV4ycUb8F
	idasPlaf46a72tIi4zFobFWQr48c30tAzlOAygWxf3pHXR95os2En7TjK3x4/msHX4bO
	3VZmFV0WTpy9F4THdO7DN3LXg6b7XFCUL2mG0=
MIME-Version: 1.0
Received: by 10.204.141.28 with SMTP id k28mr2297552bku.207.1277081887133; 
	Sun, 20 Jun 2010 17:58:07 -0700 (PDT)
Sender: julien.laffaye@gmail.com
Received: by 10.204.57.9 with HTTP; Sun, 20 Jun 2010 17:58:07 -0700 (PDT)
In-Reply-To: <201006210045.o5L0jgZ3009138@repoman.freebsd.org>
References: <201006210045.o5L0jgZ3009138@repoman.freebsd.org>
Date: Sun, 20 Jun 2010 17:58:07 -0700
X-Google-Sender-Auth: 9INDWMpwPWFHFybdaMnhNfd5ojs
Message-ID: <AANLkTilVcTOnaHwihB4IZVi7KZldCrD2Ion28XCSuOgg@mail.gmail.com>
From: Julien LAFFAYE <jlaffaye@freebsd.org>
To: Ivan Voras <ivoras@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 180026 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jun 2010 01:23:48 -0000

Hi,

On Sun, Jun 20, 2010 at 5:45 PM, Ivan Voras <ivoras@freebsd.org> wrote:
>
> http://p4web.freebsd.org/@@180026?ac=3D10
>
> Change 180026 by ivoras@betelgeuse on 2010/06/21 00:45:03
>
> =A0 =A0 =A0 =A0Finished most of +CONTENTS reading code, still a few thing=
s to go
> =A0 =A0 =A0 =A0and certainly edge-cases resulting from the uglyness and a=
dhockery
> =A0 =A0 =A0 =A0of the format.
>

Why don't you use read_plist(Package *pkg, int fd) from libpkg instead?


Regards,
Julien