From owner-freebsd-current Fri Oct 25 10:18: 2 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 869CA37B401 for ; Fri, 25 Oct 2002 10:18:00 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id A2ED443E4A for ; Fri, 25 Oct 2002 10:17:56 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 72744 invoked by uid 1000); 25 Oct 2002 17:17:57 -0000 Date: Fri, 25 Oct 2002 10:17:57 -0700 (PDT) From: Nate Lawson To: Joe Marcus Clarke Cc: John Baldwin , current@FreeBSD.org Subject: Re: libgtop port and v_tag changes In-Reply-To: <20021025123724.X78655-101000@shumai.marcuscom.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 25 Oct 2002, Joe Marcus Clarke wrote: > On Fri, 25 Oct 2002, John Baldwin wrote: > > It does?! v_tag is a pointer to kernel memory, you can't read that > > from userland! You would get a SIGSEGV and die as soon as you do the > > 'strcmp()'. That's why I #ifdef'd the whole chunk out. Also, just for > > the record, my code didn't break the non CURRENT case. :) Sorry, mispoke. Your code didn't fix the CURRENT case. :) > Gak! If Julian didn't pound kvm_read into my head before, I've got it > now. Sure, it compiles, buth then what :-}. Thanks for the pointer. > Attached is a patch to libgtop2, but should be similar if not identical to > what's needed for libgtop. Let me know if this looks a little better. > Thanks. > > Joe For another working and tested example, see rev 1.45 of fstat.c (usr.bin/fstat). -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message