From owner-svn-src-head@freebsd.org Thu Dec 24 20:57:41 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 06564A51CAB; Thu, 24 Dec 2015 20:57:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B4281823; Thu, 24 Dec 2015 20:57:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tBOKvZkx090747 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 24 Dec 2015 22:57:35 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tBOKvZkx090747 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tBOKvU3I090746; Thu, 24 Dec 2015 22:57:30 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 24 Dec 2015 22:57:30 +0200 From: Konstantin Belousov To: Bruce Evans Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292620 - head/sys/kern Message-ID: <20151224205730.GC3625@kib.kiev.ua> References: <201512222012.tBMKCqqg039018@repo.freebsd.org> <20151223073258.M993@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151223073258.M993@besplex.bde.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 20:57:41 -0000 On Wed, Dec 23, 2015 at 08:02:10AM +1100, Bruce Evans wrote: > On Tue, 22 Dec 2015, Konstantin Belousov wrote: > > > Log: > > If we annoy user with the terminal output due to failed load of > > interpreter, also show the actual error code instead of some > > interpretation. > > This and nearby messages are of annoyingly low quality. They don't > even print the program name(s). > > I use the following partial fixes. I forget if they print the program > name or the interpeter name. > > X Index: imgact_elf.c > X =================================================================== > X RCS file: /home/ncvs/src/sys/kern/imgact_elf.c,v > X retrieving revision 1.151 > X diff -u -2 -r1.151 imgact_elf.c > X --- imgact_elf.c 5 Jun 2004 02:18:28 -0000 1.151 > X +++ imgact_elf.c 5 Jun 2004 06:51:25 -0000 > X @@ -694,6 +693,6 @@ > X brand_info = __elfN(get_brandinfo)(hdr, interp); > X if (brand_info == NULL) { > X - uprintf("ELF binary type \"%u\" not known.\n", > X - hdr->e_ident[EI_OSABI]); > X + uprintf("%s: ELF binary type \"%u\" not known.\n", > X + imgp->stringbase, hdr->e_ident[EI_OSABI]); This cannot be a fix. there is no stringbase member in struct imgact. In fact, there is no available path to the executable in the image activation routine, and due to things like fexecve(2), it may have been not passed to the kernel at all. The present structure of the messages is forced by this fact, and it is usually obvious what is the image kernel complained about, since it is the image that was just executed.