From owner-svn-src-all@freebsd.org Fri Jan 5 17:28:29 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4AEC6EB588A; Fri, 5 Jan 2018 17:28:29 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8DC773A8D; Fri, 5 Jan 2018 17:28:28 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-wm0-f44.google.com with SMTP id 9so3707625wme.4; Fri, 05 Jan 2018 09:28:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TMn+VD9hm9Ofe7Bn9uJaad5PjjKUHdjYVNOkWs9mT/w=; b=h48ojFAc0AKtGnVPKid3sNeCbLmyfnrQ8dCKDuTp4xihDouDfC7VBxl/EwBGPrGmIc hTyZow4QOQl0RO3BEXCioRyp8HwT/CDoYU8jLQDbKBDtkEZMxXgAJg277L18AfWZak0r Ko9OVVDxOYKgEHU8Ne1DM/BFECTeq+RGRWueuuXtbd0/uhDgB7ngB8OB2yt0ToqmbF7b LwSiF0MtkSDc9sg8QaXwkSvo8BdUo9KQqZ8tflNduBWOIRf4vn80NMh89Oz3nCVzetJh APjRZSjoEmZ42rzkAW21mAcA8ze8rgloZ6W1HkzE590vstyjJptSS48xSMM/oaeCTLQW UWrw== X-Gm-Message-State: AKGB3mK0AkaDJVRR6K0DFA5OJ8RZb6o4uYXAX+J5y7U/wT8Hf8M0jTVn dyBWfh8l8EtAO1E7qoey1Nidw2DL X-Google-Smtp-Source: ACJfBovG1bmh5HhpIouQfR3WZg8wJCcSsuV1uXdFoGXOwwJN2BqIbLSz+5Ye/GZSDkHHo9+Q/30rVQ== X-Received: by 10.80.245.220 with SMTP id x28mr5078157edm.160.1515173300417; Fri, 05 Jan 2018 09:28:20 -0800 (PST) Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com. [209.85.128.179]) by smtp.gmail.com with ESMTPSA id b30sm4926227ede.53.2018.01.05.09.28.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2018 09:28:19 -0800 (PST) Received: by mail-wr0-f179.google.com with SMTP id l19so4928723wrc.2; Fri, 05 Jan 2018 09:28:19 -0800 (PST) X-Received: by 10.223.173.147 with SMTP id w19mr3556684wrc.214.1515173299344; Fri, 05 Jan 2018 09:28:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.160.170 with HTTP; Fri, 5 Jan 2018 09:28:18 -0800 (PST) In-Reply-To: <97d173fb-4f47-609d-8319-07282a283473@multiplay.co.uk> References: <201801042005.w04K5liB049411@repo.freebsd.org> <5A4E9397.9000308@grosbein.net> <5A4EDC62.50508@grosbein.net> <5A4F824C.1060405@grosbein.net> <97d173fb-4f47-609d-8319-07282a283473@multiplay.co.uk> From: Matt Joras Date: Fri, 5 Jan 2018 09:28:18 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327559 - in head: . sys/net To: Steven Hartland Cc: Eugene Grosbein , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 17:28:29 -0000 On Fri, Jan 5, 2018 at 7:42 AM, Steven Hartland wrote: > My current thinking is that flowid shouldn't be used for either LACP or > loadbalance protocols as doing so will almost certainly lead to unexpected > behavior (the stated lagghash may not be valid). > > Regards > Steve > For what it's worth, this was the conclusion I came to, and at Isilon we've made the same change being discussed here. For the case of drivers that end up using a queue index for the flowid, you end up with pathological behavior on the lagg; the flowid ends up getting right shifted by (default) 16. So in the case of e.g. two bxe(4) interfaces with 4 queues, you always end up choosing the interface in the lagg at index 0. This was enough to make us completely disable it. Customers started noticing when they upgraded from the BSD7-based release (which predates flowid) to the BSD10-based release. It is my impression that this sort of situation is probably more common in FreeBSD, especially since some drivers only set the flowid to an RSS hash when RSS is defined, otherwise defaulting to a queue index. Matt