From owner-svn-src-all@FreeBSD.ORG  Thu Dec  4 18:28:38 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1DA2EF57;
 Thu,  4 Dec 2014 18:28:38 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id CEA56F31;
 Thu,  4 Dec 2014 18:28:37 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 7751FA10F;
 Thu,  4 Dec 2014 18:28:36 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 03F4E1A03; Thu,  4 Dec 2014 19:28:31 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: John-Mark Gurney <jmg@funkthat.com>
Subject: Re: svn commit: r275468 - head/sys/dev/usb/controller
References: <201412032155.sB3LtjJN043364@svn.freebsd.org>
 <20141204005451.GM99957@funkthat.com> <54800B60.9020208@selasky.org>
 <20141204175032.GQ99957@funkthat.com>
Date: Thu, 04 Dec 2014 19:28:31 +0100
In-Reply-To: <20141204175032.GQ99957@funkthat.com> (John-Mark Gurney's message
 of "Thu, 4 Dec 2014 09:50:32 -0800")
Message-ID: <86sigve0c0.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Hans Petter Selasky <hps@selasky.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2014 18:28:38 -0000

John-Mark Gurney <jmg@funkthat.com> writes:
> Did you see the comment about usig __builtin_ffs{,l,ll} instead? this
> seems to be a better route...

No.  It's needlessly compiler-dependent.

> So, how about changing libkern.h to define the various ones to the
> built in, and dropping all the special versions?

This is (or should) be taken care of in cpufunc.h for platforms that
support ffs / fls in hardware.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no