From owner-freebsd-hackers@FreeBSD.ORG Sun Mar 14 05:55:36 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37689106564A; Sun, 14 Mar 2010 05:55:36 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 080AE8FC0C; Sun, 14 Mar 2010 05:55:35 +0000 (UTC) Received: by pva18 with SMTP id 18so37340pva.13 for ; Sat, 13 Mar 2010 21:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=yoWnaC/rXN0K9LfdeMIybYwglcPbS+vXuZGVdcx8sbE=; b=mHMTtCQ8SsjXyOQrjThrsskv+6H6DH4NCHT6yNBf9SWmRdwLr+eh9ShOVw5V060bf5 F8eqBr5D3vcNL2wnra35s1WLyGueBwLkRXzYoVw//DIxD6wR3aemEDDr4N6nURg6/YZl 4vNCxY+yYTIjj8lAdDIFjaKO13z9JBIgnrkKk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=AiDGcuPDm39kBFNuWpcD6rp/EaXqomHd8ObgLtruWhEAmwZ1Lz1oF57W3TPQKi/UH+ wTaCmzefc1Nb2setSpXpcIcFi+HOaJsx77NSVxSXE9wfREhFh5kH24bBbkgqJgSJMot9 YnGDkfZ5rG1vxXskh8f6Q/T25DpVT5jDLVTp0= MIME-Version: 1.0 Received: by 10.143.27.20 with SMTP id e20mr4135841wfj.256.1268546135372; Sat, 13 Mar 2010 21:55:35 -0800 (PST) In-Reply-To: <4B9C72FE.2060907@FreeBSD.org> References: <4B9C72FE.2060907@FreeBSD.org> Date: Sat, 13 Mar 2010 21:55:35 -0800 Message-ID: <7d6fde3d1003132155t3059a438m80bd50fdf1dbe091@mail.gmail.com> From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org, Doug Barton Subject: Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 05:55:36 -0000 On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton wrote: > On 03/13/10 05:52, Alexander Best wrote: >> hello, >> >> this patch fixes the following gcc warning: > > For all such issues, please file a PR first so it doesn't get lost. When > you get the PR confirmation back, feel free to alert the list to its > existence. Yes, please submit a proper PR for this because it's a code bug; FYI, your solution isn't complete though (it's close): ABORT(3) FreeBSD Library Functions Manual ABORT(3) NAME abort -- cause abnormal program termination LIBRARY Standard C Library (libc, -lc) SYNOPSIS #include void abort(void); Please be explicit and add stdlib.h. Thanks, -Garrett