From owner-freebsd-stable@FreeBSD.ORG Tue Feb 10 06:28:02 2009 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1669E106566B for ; Tue, 10 Feb 2009 06:28:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id AD22A8FC0A for ; Tue, 10 Feb 2009 06:28:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LWm6C-000Myq-0x; Tue, 10 Feb 2009 08:28:00 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n1A6Rvli065788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 Feb 2009 08:27:57 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n1A6Rv4s021187; Tue, 10 Feb 2009 08:27:57 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n1A6RvYr021186; Tue, 10 Feb 2009 08:27:57 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 10 Feb 2009 08:27:57 +0200 From: Kostik Belousov To: Eugene Grosbein Message-ID: <20090210062757.GK9427@deviant.kiev.zoral.com.ua> References: <498FAA2A.7423AC15@kuzbass.ru> <20090209214822.GH9427@deviant.kiev.zoral.com.ua> <20090210040125.GA80054@svzserv.kemerovo.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J3rqiH0DIeiRD2zz" Content-Disposition: inline In-Reply-To: <20090210040125.GA80054@svzserv.kemerovo.su> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LWm6C-000Myq-0x 13e838e2e14f003f2194599b343a470c X-Terabit: YES Cc: stable@freebsd.org Subject: Re: sysctl lock in RELENG_6 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2009 06:28:02 -0000 --J3rqiH0DIeiRD2zz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 10, 2009 at 11:01:25AM +0700, Eugene Grosbein wrote: > On Mon, Feb 09, 2009 at 11:48:22PM +0200, Kostik Belousov wrote: >=20 > > > I've digged commit logs a bit and found this change MFC'd to RELENG_7 > > > but not RELENG_6: > > >=20 > > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/kern_sysctl.c#rev1= .177.6.2 > > >=20 > > > It seems RELENG_6 needs this too, doesn't it? > > > I'm going to merge the change to RELENG_6 and give it a try. > >=20 > > Yes, please give it a try. In fact, it was quite specific situation > > that I observed and produced a fix for. You need execing process that > > needs to grab Giant, e.g. due to image being located on !MPSAFE fs, and > > simultaneous sysctl issued that inspects this process. >=20 > Well, my 6.3-STABLE locked very often (sometimes every hour). > Yesterday I've upgraded it to 6.4-STABLE, applied 1.177.2.1 of the file > to sources, rebuilt NanoBSD image and ran it. It has not locked yet. Can you be slightly more scientific in your tests ? Try RELENG_6 without my patch to see whether it is needed at all. >=20 > Btw, root filesystem here is UFS2 without softupdates mounted read-only > but /etc and /var are md(4) (devfs is mounted too). >=20 > Eugene Grosbein --J3rqiH0DIeiRD2zz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmRHmsACgkQC3+MBN1Mb4idjgCeM2VBjzFz3km/3vsOt4w/qGXF U/UAn30OB6pjq2UMzy4oZSfFab+Oq8Qs =ZJzE -----END PGP SIGNATURE----- --J3rqiH0DIeiRD2zz--