From owner-svn-src-head@FreeBSD.ORG Wed Jan 21 08:00:19 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 58BC9E56; Wed, 21 Jan 2015 08:00:19 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D28F976D; Wed, 21 Jan 2015 08:00:18 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::5529:9fa5:cf6:9530] (unknown [IPv6:2001:7b8:3a7:0:5529:9fa5:cf6:9530]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 2A1F85C2E; Wed, 21 Jan 2015 09:00:08 +0100 (CET) Subject: Re: svn commit: r276485 - in head/sys: conf dev/cxgbe modules/cxgbe/if_cxgbe Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: multipart/signed; boundary="Apple-Mail=_CE364395-FE82-4164-9419-8596551839E5"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b4 From: Dimitry Andric In-Reply-To: <20150121055329.GB3307@ox> Date: Wed, 21 Jan 2015 09:00:03 +0100 Message-Id: <98838DA6-1969-4764-83DE-71F7BB568E23@FreeBSD.org> References: <201412312319.sBVNJHca031041@svn.freebsd.org> <20150106203344.GB26068@ox> <54BEE07A.3070207@FreeBSD.org> <54BEE305.6020905@FreeBSD.org> <54BEF7CF.9030505@FreeBSD.org> <20150121021905.GA73548@FreeBSD.org> <54BF1EB0.2080901@FreeBSD.org> <20150121055329.GB3307@ox> To: Navdeep Parhar X-Mailer: Apple Mail (2.1993) Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Pedro Giffuni , "svn-src-head@freebsd.org" , Luigi Rizzo X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 08:00:19 -0000 --Apple-Mail=_CE364395-FE82-4164-9419-8596551839E5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 21 Jan 2015, at 06:53, Navdeep Parhar wrote: >=20 > On Tue, Jan 20, 2015 at 10:36:16PM -0500, Pedro Giffuni wrote: >>=20 >> On 01/20/15 22:06, Adrian Chadd wrote: >>> On 20 January 2015 at 18:19, Alexey Dokuchaev = wrote: >>>> On Tue, Jan 20, 2015 at 07:50:23PM -0500, Pedro Giffuni wrote: >>>>> But the fix is rather ugly, isn't it? I would personally prefer to = just >>>>> kill the older gcc but in the meantime updating it so that it = behaves >>>>> like the updated gcc/clang would be better. IMHO. >>>> Seconded. Putting extra harness on the code to avoid bugs in the = compiler >>>> that were actually fixed upsteam is totally bogus. >>> Right, but: >>>=20 >>> * not all of us work on compilers; >>> * not all of us want to currently be working on compilers; >>> * some of us have to use the gcc that's in tree; >>> * .. and apparently updating that gcc to something > 4.2 is = verboten. >>=20 >> The external toolchain can't be that bad(?). >>=20 >>> So if someone wants to help Navdeep by backporting those options, >>=20 >> Hmm .. didn't I post a patch? >>=20 >>> please do. I bet he'd love the help. >>>=20 >> Ugh he doesn't and TBH, I don't care enough to look for >> consensus either. >=20 > Let's please just move on from this discussion then. I am not = familiar > with gcc internals so I can't vouch for this patch, and gcc is the > default compiler on platforms that I cannot test. Given that, it = would > be reckless of me to push a gcc patch just to get it to play nice with > one single file in the tree. High risk, little reward (given that > -fms-extensions can be applied to just the file in question without > disturbing anything else in the tree). Alternatively, just use the ${GCC_MS_EXTENSIONS} Makefile macro, which I specifically introduced for this issue. See e.g. sys/modules/ibcore/Makefile for an example. -Dimitry --Apple-Mail=_CE364395-FE82-4164-9419-8596551839E5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlS/XIYACgkQsF6jCi4glqMLNgCfTU7AL+edjlRlCpRA1CDPdFnZ k4QAni+w/Q/CjcwMiY9RLVLD5NJ3apiD =wRrZ -----END PGP SIGNATURE----- --Apple-Mail=_CE364395-FE82-4164-9419-8596551839E5--