From owner-freebsd-ports Sun Feb 3 14: 7:59 2002 Delivered-To: freebsd-ports@freebsd.org Received: from dppl.com (sapas.dppl.biz [216.182.10.231]) by hub.freebsd.org (Postfix) with ESMTP id 7E0C737B404 for ; Sun, 3 Feb 2002 14:07:44 -0800 (PST) Received: from volyn.coolrat.org (bgp431251bgs.union01.nj.comcast.net [68.36.218.89]) (AUTH: PLAIN yds, TLS: TLSv1/SSLv3,168bits,DES-CBC3-SHA) by dppl.com with esmtp; Sun, 03 Feb 2002 17:07:38 -0500 Date: Sun, 03 Feb 2002 17:07:06 -0500 From: Yarema To: Alex Dupre Cc: Ports FreeBSD Subject: Re: pdflib 4.0.2 Message-ID: <1368130000.1012774025@volyn.coolrat.org> In-Reply-To: <3C5D042E.4090900@alexdupre.com> References: <3C5C283E.9020301@alexdupre.com> <936270000.1012673656@volyn.coolrat.org> <3C5C35A0.4070809@alexdupre.com> <977910000.1012680496@volyn.coolrat.org> <3C5C6FAE.7080605@alexdupre.com> <1055040000.1012695641@volyn.coolrat.org> <3C5D042E.4090900@alexdupre.com> X-Mailer: Mulberry/2.1.2 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --On Sunday, February 03, 2002 10:34:38 +0100 Alex Dupre wrote: > Yarema wrote: >> I tried it that way and didn't particularly like it because you're still >> not using the FreeBSD installed libtool. > > Why not? LIBTOOLFILES simply contains the path of aclocal.m4 to be > patched so it could find FreeBSD libtool (it changes two file references > inside aclocal.m4). Since pdflib aclocal.m4 is not in the base dir, but > in /config/ , it's necessary to define LIBTOOLFILES. I was aware of the /config/aclocal.m4 issue. The problem is that all the Makefile.in files in all the subdirectories contain: LIBTOOL = $(top_builddir)/libtool --silent and $(top_builddir) is definded as '..' or '../..' essentially $(top_builddir) == ${WRKSRC} >> The reason I rolled that >> post-patch target was to avoid using the libtool provided by pdflib >> itself. If LIBTOOLFILES does not point at an aclocal.m4 then USE_LIBTOOL >> patches configure itself to use I was just >> helping it along by patching all the Makefile.in files to do what >> USE_LIBTOOL does to the configure script. > > I don't understand what you mean. So given what I said above. I was "fixing" pdflib's Makefile.in files to respect what USE_LIBTOOL and LIBTOOLFILES "intend" for the build process to do. Which is use /usr/local/bin/libtool. >> Granted that your way works, but the reason USE_LIBTOOL was invented was >> to avoid relying on the libtool provided by the vendor which might not >> always do things the "FreeBSD way". > > In fact it doesn't use the libtool provided (?) by pdflib. Well, it does use the libtool which is created from /config/aclocal.m4 and is not the same as /usr/local/bin/libtool. Watch the build and you'll see that it's always ../libtool or ../../libtool. Both ways work and in the case of pdflib seem to do the same thing. But back in the day when the various LIBTOOL macros were created I believe the intent was to create a FreeBSD specific set of defaults in libtool which may be different than the defaults provided by rolling a libtool from code in the package you're building. -- Yarema To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message