Date: Sat, 04 Jan 2014 08:26:46 -0800 (PST) From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: ashish@FreeBSD.org Subject: ports/185468: [PATCH] editors/emacs: Do not launch emacs from a terminal when X11 is set (r338450 regression) Message-ID: <52c83646.e684700a.19bb.6a27@mx.google.com> Resent-Message-ID: <201401041630.s04GU0dc010701@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 185468
>Category: ports
>Synopsis: [PATCH] editors/emacs: Do not launch emacs from a terminal when X11 is set (r338450 regression)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 04 16:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Raphael Kubo da Costa
>Release: FreeBSD 11.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD orwell 11.0-CURRENT FreeBSD 11.0-CURRENT #5 r259799: Tue Dec 24 03:24:18 EET
>Description:
Fix a regression introduced in r338450 that reversed the logic in the check for whether the X11 option is set or not: before, it checked for WITHOUT_X11 to set Terminal to true in the desktop file, whereas the code was now setting that _if_ X11 was set.
Port maintainer (ashish@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.99_11 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:
--- emacs24-24.3_2,3.patch begins here ---
diff -ruN /usr/ports/editors/emacs/Makefile ./Makefile
--- /usr/ports/editors/emacs/Makefile 2014-01-04 18:19:26.000000000 +0200
+++ ./Makefile 2014-01-04 18:18:14.000000000 +0200
@@ -1,9 +1,9 @@
# Created by: MANTANI Nobutaka <nobutaka@nobutaka.com>
-# $FreeBSD: editors/emacs/Makefile 338536 2014-01-03 10:55:40Z ashish $
+# $FreeBSD: head/editors/emacs/Makefile 338536 2014-01-03 10:55:40Z ashish $
PORTNAME= emacs
PORTVERSION= ${EMACS_VER}
-PORTREVISION?= 1
+PORTREVISION?= 2
PORTEPOCH= 3
CATEGORIES= editors ipv6
MASTER_SITES= ${MASTER_SITE_GNU}
--- emacs24-24.3_2,3.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52c83646.e684700a.19bb.6a27>