From owner-freebsd-ports@freebsd.org Thu Aug 9 02:31:15 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F5621075EC0 for ; Thu, 9 Aug 2018 02:31:15 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D9F997A43B for ; Thu, 9 Aug 2018 02:31:14 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: by mailman.ysv.freebsd.org (Postfix) id 9B8FD1075EBD; Thu, 9 Aug 2018 02:31:14 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79B7F1075EBB for ; Thu, 9 Aug 2018 02:31:14 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: from mx12-out5.antispamcloud.com (mx12-out5.antispamcloud.com [46.165.232.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 108287A435 for ; Thu, 9 Aug 2018 02:31:13 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: from [153.92.8.106] (helo=srv31.niagahoster.com) by mx66.antispamcloud.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1fnaik-0002qG-F8; Thu, 09 Aug 2018 04:31:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sumeritec.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cLaEBtmK6SvEcECSvMaTUfuIxy9VpWS0kPDCH6yT3wc=; b=Oc9DGkCvYgnTpLQyDfiRu0HMgF Clu/EERbxf7ICOT3pE8JbZBrqzWZjFs4r2UzaSzVY1ep1f3dR834Rg0IPWi82tCeQO266YgCD1JiF Py+W4XFgv8Zma0onpiOGRrpvOD91ZBpkkuHslNBFUPt+Gn5+6sc0nLS116C4KRc/qz89Vup45gFef 2ZLcsb55o/LTKvd6JZ4C9/S7Hp4HHJy+RQbrfPPUNDEfuYRm4XvhrmquOFq7zMJU9td5sytO8mZR5 NMnNbVvG5GW272Hzf6eYWbSNYuNUB9LD32SBW1J9VrWU2QzZkOTvjFLIJzVSy72ddOvGf8EknqEgK dNqDKZvw==; Received: from [114.125.109.168] (port=42220 helo=X220.sumeritec.com) by srv31.niagahoster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnahu-0000Hg-G0; Thu, 09 Aug 2018 09:29:50 +0700 Date: Thu, 9 Aug 2018 10:29:43 +0800 From: Erich Dollansky To: "ports@freebsd.org" Cc: A.J.Caines@halplant.com Subject: Blackbox does not compile, diff in here Message-ID: <20180809102943.3ab85fce.freebsd.ed.lists@sumeritec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.0 X-AuthUser: freebsd.ed.lists@sumeritec.com X-Originating-IP: 153.92.8.106 X-AntiSpamCloud-Domain: out.niagahoster.com X-AntiSpamCloud-Username: niaga Authentication-Results: antispamcloud.com; auth=pass (login) smtp.auth=niaga@out.niagahoster.com X-AntiSpamCloud-Outgoing-Class: ham X-AntiSpamCloud-Outgoing-Evidence: Combined (0.03) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5l4I+tVsi89SZ0Qc1fuEmJ5602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO5RRcl3opkyrg0+i43ZIN+QDLMDOMhSJZfbuW4QsZQcfF+hgdhufAYJKZ4f3fuz9q0UW C04XSAzD9BY3jWqrMAwgdK1XkOIbSHuV3Lpuu4FfFI/Eie+XPWXdaSJPpTOrKkZG8oN1iDmTG7Hg JoA5koLVemoUPJMHUHPSf9ssABRg7tX1JIIXdACoWW+Y4L3+Wy2uPSeJT5I8TpI9bg3giwaVsm4m 7ikBKJfWQhJIAf1QBsOYgCa6Bo6Lu8GdpHLwk26noxJ1R+JPOFQkdVRSeviFcFhO9Ph08zfxywcA n5TeB3PPZVJXzRiDtPk9EjJJjxtDCxbtr+uPmhy8lPsq5IyFaqgcGzZnX+CJEzOKknaQz78Xrhgj TUn5sMQIm1FXCn2M56NQTHXUYMGv32pVQuxNJEoSvoLoS7xPGRwSbFHfkVWClPVvbW5lVyQanRxw 5hi8a1G7BFro2SbAGuw+CyWdJht6oYCvQvY3kH+XsZTQA81W/FNgiwWJGIyXhpjjHkRE5KNIYL4T Oer9CexvGTHKUUJG8B/fxX0TdfB5s6fHk5PqSEEDYXnfjF2vgmVbqaYkeqNB5N0z7Fwcuki6mVEA EiHu8ZhCChRlnKWnZpS54LSZoIZde+3uPdV9etEiA8zJISPt/AvPfecye3y/ZUA1RalDwJQgBpmX a8cH4xBMYxyasZMgEFn9NeF+MnwAPUGbOIlwP6U7nXQC9ighjoxY+b9ixPPW74g+kIpEo1csJyrJ B6q62m5zoTwwfO6oRCmBbeacOPnHEOWEFwOLsKX+0BWXgkXg4qhoZcXVnyJVjttAJ9vYj8Ojq5f6 ZTCiNY0p+LNPk4iPol61HlTzCg9WBb39uS1TjWG2Inx+Ts2Q0IhWJgCi1I5NpHyY7bC62Uk1f3Xo tzgoeKtj35zl+Z6vMdqIruBDTSEq9qNmK7Uo X-Report-Abuse-To: spam@quarantine1.antispamcloud.com X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 02:31:15 -0000 Hi, I do not know if somebody spotted this already. Some casting was done to the wrong types. Erich PS I am not experienced in creating diffs for ports. This one was done in the working directory's lib entry: --- EWMH.cc.180809 2005-01-24 15:50:56.000000000 +0800 +++ EWMH.cc 2018-08-09 10:10:05.630203000 +0800 @@ -204,7 +204,7 @@ bool bt::EWMH::readNumberOfDesktops(Window target, unsigned int* number) const { unsigned char* data = 0; - if (getProperty(target, XA_CARDINAL, net_number_of_desktops, &data)) { + if (getProperty (target, XA_CARDINAL, net_number_of_desktops, &data)) { *number = static_cast(*(reinterpret_cast(data))); @@ -246,8 +246,11 @@ void bt::EWMH::setDesktopViewport(Window target, int x, int y) const { + // + // 09.08.18 ed: the following statement was modified. + // const unsigned long viewport[] = - { static_cast(x), static_cast(y) }; + { static_cast(x), static_cast(y) }; setProperty(target, XA_CARDINAL, net_desktop_viewport, reinterpret_cast(viewport), 2); } @@ -644,8 +647,10 @@ } -bool bt::EWMH::getProperty(Window target, Atom type, Atom property, - unsigned char** data) const { +bool bt::EWMH::getProperty (Window target, + Atom type, + Atom property, + unsigned char ** data) const { Atom atom_return; int size; unsigned long nitems, bytes_left;