From owner-freebsd-net Thu Oct 3 3: 2:56 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27AE137B401; Thu, 3 Oct 2002 03:02:50 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F99C43E77; Thu, 3 Oct 2002 03:02:49 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA06810; Thu, 3 Oct 2002 20:02:47 +1000 Date: Thu, 3 Oct 2002 20:12:26 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Robert Watson Cc: net@FreeBSD.ORG Subject: Re: NFS client code calls sosend() directly... In-Reply-To: Message-ID: <20021003200757.K3283-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Wed, 2 Oct 2002, Robert Watson wrote: > While I was reviewing the rest of the kernel tree, I also found... > > /cboss/p4/rwatson/trustedbsd/mac/sys/fs/fifofs/fifo_vnops.c: > > error = sosend(wso, (struct sockaddr *)0, ap->a_uio, 0, > > /cboss/p4/rwatson/trustedbsd/mac/sys/fs/portalfs/portal_vnops.c: > > error = sosend(so, (struct sockaddr *) 0, &auio, > > These also strike me as similarly incorrect and fixable. Of course, > fifofs and portalfs are both home to much evil, so... What evil is that, in the case of fifofs? fifofs is fairly simple and clean. It needs particular socket semantics (simple ones which it has set up), so it can know that sosend() does the right thing for it. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message