Date: Thu, 3 Oct 2002 20:12:26 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Robert Watson <rwatson@FreeBSD.ORG> Cc: net@FreeBSD.ORG Subject: Re: NFS client code calls sosend() directly... Message-ID: <20021003200757.K3283-100000@gamplex.bde.org> In-Reply-To: <Pine.NEB.3.96L.1021002143239.46964J-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2 Oct 2002, Robert Watson wrote: > While I was reviewing the rest of the kernel tree, I also found... > > /cboss/p4/rwatson/trustedbsd/mac/sys/fs/fifofs/fifo_vnops.c: > > error = sosend(wso, (struct sockaddr *)0, ap->a_uio, 0, > > /cboss/p4/rwatson/trustedbsd/mac/sys/fs/portalfs/portal_vnops.c: > > error = sosend(so, (struct sockaddr *) 0, &auio, > > These also strike me as similarly incorrect and fixable. Of course, > fifofs and portalfs are both home to much evil, so... What evil is that, in the case of fifofs? fifofs is fairly simple and clean. It needs particular socket semantics (simple ones which it has set up), so it can know that sosend() does the right thing for it. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021003200757.K3283-100000>