From nobody Thu May 1 23:21:12 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZpVRY2Hkvz5tdyH; Thu, 01 May 2025 23:21:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZpVRX6gCxz40q7; Thu, 01 May 2025 23:21:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746141672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nFywYJah0gyXAcV2ABl3CjtecIRLNqyYvTabHGfWUQA=; b=OReOhYvORFXxUAaHiYAMz/R/YdPss3GK7UrPKKoCLTuY1dxGnncN5D4rFr2gy9NZVC3G58 2Aco1ehd9GiH7CiFWAh85Wlci9Fu5s2vWw9Z82n6wjQ5slyCXygXqc15RehMGM3gXKNZDZ UmaVAh0pAuDrS12yfwyNxKld2wVvx+7mhG0Sy+ITrWrhVapkvupM+8+Sd6F8fpPsa1CjTz Jun+YREjT8yPmbWGKOtfGwklRr3Ii8nqb6ovtSST3bk87UHXuG9Yatc5/nUNANjYzbHkaS EEhzz3wMmDhykb4Kt+fL8POVBt1xg6R363yIqz1TuVe3AhYnd+PJRxuraK/tEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746141672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nFywYJah0gyXAcV2ABl3CjtecIRLNqyYvTabHGfWUQA=; b=adBA48U7LDL1UBI9TT2Req8dXH4BAVyCchmcrGbNilCE9ncpb9HGf2eZpM59mRExWK1FxS FTndeRK2/tEFQOm7TAqCE/ZmWRY+FXxzSzGpbaxZefaAe5MuJVM6mRlcYSeumPQNy6wzB1 /tCdqAarfiUN9Zj6gFmTzfCKaYML+nqEjfnaCt1l41TVwLZGcoya3qHOOry8tFXR+E+PVC ecjCDK/48AXpzifQimAhgPzD1SUdjT9Ijw1wZEkHyYGuRP+VhRrvhGuLxk5EYaesfAN7I1 qcGefiMQ4RjvKyN2bKkK+q67ws5MPHLpUtUM6O+E9mxRHKVy8iq7B/PrUVyYhw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746141672; a=rsa-sha256; cv=none; b=uKZuvbYjucA0PZbPZ1yKNIFV0srfDDT3pSMcKisSVb1f+xcEUzbhQG1tIDgBMaOTMye9IZ cgyd2EMClwscKLSc3dFalooxKWJbbudluguHThtxYijE48+g8TW6pFaApQJ7/Ps7dykZbI mQTX1QZsdy1bM7gviID10UyfmnBWqRmtv/LQY/1+Aectk3RWAD848KeAGy/QMN5Au2yjFe yo/0wFP16nnhLO9GQ7dojLVcmsDVhxalGhlV7xdtQmsiOSt8aIs272GVvexNJwmHQgAMf+ VaiJKNpbzYAg1WBX55NlMzujalOKIOOh7Oo6Kb4ZUTF22v8Y/9HDcqftLHcxrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZpVRX6GhyzpVt; Thu, 01 May 2025 23:21:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 541NLCfF060136; Thu, 1 May 2025 23:21:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 541NLCiP060133; Thu, 1 May 2025 23:21:12 GMT (envelope-from git) Date: Thu, 1 May 2025 23:21:12 GMT Message-Id: <202505012321.541NLCiP060133@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 68daa781c1f1 - main - mountd: Fix updating the network/host(s) for an exports line List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 68daa781c1f12e1cfef768030eaff970c3d35543 Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=68daa781c1f12e1cfef768030eaff970c3d35543 commit 68daa781c1f12e1cfef768030eaff970c3d35543 Author: Rick Macklem AuthorDate: 2025-05-01 23:17:20 +0000 Commit: Rick Macklem CommitDate: 2025-05-01 23:17:20 +0000 mountd: Fix updating the network/host(s) for an exports line Mountd reloads the exports(5) file(s) when it receives a SIGHUP and then compares the old and new exports, updating any ones that have changed in the kernel. Without this patch, mountd failed to recognize that a network/host(s) had changed, if there was no other change to the exports line. As such, the change of network/hosts(s) did not take effect until the mountd daemon was (re)started. This patch fixes the code so that it checks for changes in the network/host(s) list for an exports line. PR: 286260 MFC after: 3 days --- usr.sbin/mountd/mountd.c | 44 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c index 2969edd8aed5..7e2f9b6e73bd 100644 --- a/usr.sbin/mountd/mountd.c +++ b/usr.sbin/mountd/mountd.c @@ -231,6 +231,7 @@ static void free_exports(struct exportlisthead *); static void read_exportfile(int); static int compare_nmount_exportlist(struct iovec *, int, char *); static int compare_export(struct exportlist *, struct exportlist *); +static int compare_addr(struct grouplist *, struct grouplist *); static int compare_cred(struct expcred *, struct expcred *); static int compare_secflavor(int *, int *, int); static void delete_export(struct iovec *, int, struct statfs *, char *); @@ -2336,7 +2337,8 @@ compare_export(struct exportlist *ep, struct exportlist *oep) grp->gr_exflags == ogrp->gr_exflags && compare_cred(&grp->gr_anon, &ogrp->gr_anon) == 0 && compare_secflavor(grp->gr_secflavors, - ogrp->gr_secflavors, grp->gr_numsecflavors) == 0) + ogrp->gr_secflavors, grp->gr_numsecflavors) == 0 && + compare_addr(grp, ogrp) == 0) break; if (ogrp != NULL) ogrp->gr_flag |= GR_FND; @@ -2349,6 +2351,46 @@ compare_export(struct exportlist *ep, struct exportlist *oep) return (0); } +/* + * Compare the addresses in the group. It is safe to return they are not + * the same when the are, so only return they are the same when they are + * exactly the same. + */ +static int +compare_addr(struct grouplist *grp, struct grouplist *ogrp) +{ + struct addrinfo *ai, *oai; + + if (grp->gr_type != ogrp->gr_type) + return (1); + switch (grp->gr_type) { + case GT_HOST: + ai = grp->gr_ptr.gt_addrinfo; + oai = ogrp->gr_ptr.gt_addrinfo; + for (; ai != NULL && oai != NULL; ai = ai->ai_next, + oai = oai->ai_next) { + if (sacmp(ai->ai_addr, oai->ai_addr, NULL) != 0) + return (1); + } + if (ai != NULL || oai != NULL) + return (1); + break; + case GT_NET: + /* First compare the masks and then the nets. */ + if (sacmp((struct sockaddr *)&grp->gr_ptr.gt_net.nt_mask, + (struct sockaddr *)&ogrp->gr_ptr.gt_net.nt_mask, NULL) != 0) + return (1); + if (sacmp((struct sockaddr *)&grp->gr_ptr.gt_net.nt_net, + (struct sockaddr *)&ogrp->gr_ptr.gt_net.nt_net, + (struct sockaddr *)&grp->gr_ptr.gt_net.nt_mask) != 0) + return (1); + break; + default: + return (1); + } + return (0); +} + /* * This algorithm compares two arrays of "n" items. It returns 0 if they are * the "same" and 1 otherwise. Although suboptimal, it is always safe to