From nobody Mon May 4 20:59:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g8Yt91zK4z6cQxq for ; Mon, 04 May 2026 20:59:29 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yx1-xb132.google.com (mail-yx1-xb132.google.com [IPv6:2607:f8b0:4864:20::b132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g8Yt871Zvz3gdF for ; Mon, 04 May 2026 20:59:28 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yx1-xb132.google.com with SMTP id 956f58d0204a3-651c5d525f6so4191358d50.3 for ; Mon, 04 May 2026 13:59:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777928366; cv=none; d=google.com; s=arc-20240605; b=Qy7FLt8Z6sG+FKx+SVZXsFtl8GSx9fUnicg01eYgjH99PzlaLHRNf4z2fkSIA+/HgH ltyAZIGWUjlkn7Yrg0mmKhzJtVfVlLKZRYnY5T6Ex/f8XbbJRIR+nhA1BLahn0wuwCcb TCAFd+gliL/YxJIvRvfL+y7JKaAEjPMvEwiTmRhMn5PCg1Os5biqxtGnpl7wrfhEauT1 g82tpoDvAGdJin9kJ4fOamhSlIRlj7hjquX5in1P+5jOAYC+fsg+mRLl2gDsgow3I9gJ y8umd1NdAYdZMFGxPsJ5eGsIHKJsBXCOVEnlGbzqFFa5mOIc02CXrkMV8Lz+DNqKwRcv Mr1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dkim-signature; bh=+rAGedD6vDvl3FBbMUZx2Mw0OId1sF03Se0KPGkJ/FY=; fh=n9yYjyrZHwXFej3l/JsXbnVbQPBZs6Q+MPkIlKUoJBs=; b=XuROtfQp9yPJA1wFQejyhFUW2iuoROCdH2GT1NVhU/GkY1y3jJx6wDinfm2xEEoX4b ltEhpyFvAaL9Z/GWp+KUg5wbzE+DoWzQy2O8O2X7j8PaMLsD/xbTRDZpM8mR3llbnNBS 6OERoy9kPoi/kUZ49/TeRD0LL0smBFcfpYgSs45npm2xN0oizSw+ZcOqCFpWly0ztq7r khqrVeAXqeIM68S9APenXdtdceKZJFcXLZB6UN5akagsmkr2ZrJYIkJ3KGn3gODVg2fK Rm5KnX1+iUx3GLmLhTRfV78OCZH+a401FsE2F6UFtZVB7ErtEEgFNgitiGF4c6/kCck7 Yx3w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777928366; x=1778533166; darn=freebsd.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+rAGedD6vDvl3FBbMUZx2Mw0OId1sF03Se0KPGkJ/FY=; b=aQlZNACntaQV/ypMNWUVbBFK9SVzKNq64fnjHPAFrbpeg67TWFewQ7KaC0HwED9Bb3 a3KBpkobP4dt3MAzbtre2hjGH/cDatSPKZuSlXinriIOh6O1dVKnxMh+tUMnMMZ+4aX2 VRqx6nS9IenYVD5L3jFFzUQp7L95KdiZ/zS6euK1BrvOK4Pfl65Oy5LFn0syiOHxv0xt wtjY8tsKtDnz3rLWAZyWN0mGpT5QK8TiHSKFVnyNLrDi+TskIHzL554C1AUzuojZ2PpB 6lBFVjXMCNeZW2JHxEqkgm6NXIhJGJdDXu54+n4UJOncARc9W+ylhSxR2w8wjLp4tJW/ Z5rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777928366; x=1778533166; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rAGedD6vDvl3FBbMUZx2Mw0OId1sF03Se0KPGkJ/FY=; b=YhNL2jewvwt7m6Vc/gArgRqIAHqQ55yvzj0yrypR3sxWOWwPXUCoImyvfJFcWBV9Qj QJmy2/t4vQ74tbjQjLfJ/V0x/QrxJVdGe3FMCCOAvEkfaSoy52v1CysupFXX+BKmrqpY woC0M/bNaXfIPRyf+3I5atpcXgJpibVMUKXtDT25UWdbGCxnq1P3tM+9gyB3my3waGJ/ 2oCk1OIBEx+QuRs2U64mfKHjIzDfnswEig1L7Zuqp7xMq86n9IHBKZBDNjTX23xNKzRV TroMuFiOSadEqE9BQWgx1iIB4UXvsmEd1X/93tCWVV74FknQjiRW12/y0wHJxDIH2Z1p 4Lcw== X-Forwarded-Encrypted: i=1; AFNElJ9kWvVfuMFXm9MzNMGwWMSK/UQj+Pfgj6cY2kZ5CHogsu4CcNuewy4AxZgejAomiPjlmQB7AtEBeTUCOFWiYNyN88ZePw==@freebsd.org X-Gm-Message-State: AOJu0YxZkEZDx6BXDMJWVuOEzpfBi9TTqpau4vltVCtLA3Jf/FUVuyJj 0Cl/wLffVP5mV5xIHUj3fMnCp9AYAbyxdQqtawMIOGDKgMvcKRGoK/BxA1sFWcGVHaPbpLquHuk oAYqqH/7wmf8VriOPD7QfeIbRhlgaun8= X-Gm-Gg: AeBDiesXnQD6NuC9jgAWss+7rgEIQzZc1AD5PpGgxftrdtu6S0K6kbB0X/HBFfbjDV7 EscieNuLGdEo3aqEsWAiGlWroo8KAC4o+p17tc+kFLGday56PabvesWjdUNpHx0NRDdIbdVGcoX FAUuQZ7/vTtxwwjZ6pmDfQFskHES9J+Lcmua3wAFffI7e5f2JLewoD9P5MfMK9PEtKrUvsCFaBV kg9GZRCZjNWRF3fpPUdMS5MbbzsBlE8/Of3DwCEBVY+5Yf5kRZdOHPhpuhVuQQeQ0xB4byHngvW SRlai+B56TFoOcydTRF4o3tZqTFm0FS+IdRStkC4fxPAttAcoqs= X-Received: by 2002:a05:690e:d5a:b0:651:b67e:6e58 with SMTP id 956f58d0204a3-65c3d9a379amr10654700d50.7.1777928366164; Mon, 04 May 2026 13:59:26 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Received: by 2002:a05:7011:a1cb:b0:515:3e23:509f with HTTP; Mon, 4 May 2026 13:59:24 -0700 (PDT) In-Reply-To: <14577.1777919687@kaos.jnpr.net> References: <69e8f964.39869.24418b55@gitrepo.freebsd.org> <86jyts1xzr.fsf@ltc.des.dev> <15177.1777314263@kaos.jnpr.net> <86bjf41chq.fsf@ltc.des.dev> <24831.1777314998@kaos.jnpr.net> <6875.1777333471@kaos.jnpr.net> <6906.1777574491@kaos.jnpr.net> <14577.1777919687@kaos.jnpr.net> From: Oliver Pinter Date: Mon, 4 May 2026 21:59:24 +0100 X-Gm-Features: AVHnY4KqwATf_61TGu3cocY3DWtVNPynoPJq-WNDTVpUgDh_i3Gv5a7R1iXnqcQ Message-ID: Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently To: "Simon J. Gerraty" Cc: "Enji Cooper (yaneurabeya)" , =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000b38fa80651043442" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4g8Yt871Zvz3gdF X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --000000000000b38fa80651043442 Content-Type: text/plain; charset="UTF-8" Hi! On Monday, May 4, 2026, Simon J. Gerraty wrote: > Simon J. Gerraty wrote: > > > Oliver Pinter wrote: > > > Could you please add some unit test for the supported use cases to > > > avoid future confusions? > > > > Sure. safe_eval.sh is setup to support that. > > https://reviews.freebsd.org/D56795 > > Not sure if anything else needs updating. Thanks! I've seen that it tests for ``, but what's about $()? Tests work as expected from src tree. > --000000000000b38fa80651043442 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi!

On Monday, May 4, 2026, Simon J. Gerraty <sjg@juniper.net> wrote:
Simon J. Gerraty <sjg@juniper.n= et> wrote:

> Oliver Pinter <oliver.pntr= @gmail.com> wrote:
> > Could you please add some unit test for the supported use cases t= o
> > avoid future confusions?
>
> Sure.=C2=A0 safe_eval.sh is setup to support that.

https://re= views.freebsd.org/D56795

Not sure if anything else needs updating.

T= hanks! I've seen that it tests for ``, but what's about $()?

Tests work as expected from src tree.
--000000000000b38fa80651043442--