Date: Tue, 03 Sep 2019 14:08:08 -0000 From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: rgrimes@freebsd.org Cc: Warner Losh <imp@bsdimp.com>, Alan Somers <asomers@freebsd.org>, Justin Hibbits <chmeeedalf@gmail.com>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf Message-ID: <201904201915.x3KJFxp3023899@gndrsh.dnsmgr.net> In-Reply-To: <201904201859.x3KIxd9J023812@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> > On Sat, Apr 20, 2019, 7:47 AM Alan Somers <asomers@freebsd.org> wrote: > > > > > On Sat, Apr 20, 2019 at 7:23 AM Justin Hibbits <chmeeedalf@gmail.com> > > > wrote: > > > > > > > > > > > > > > > > On Sat, Apr 20, 2019, 08:21 Alan Somers <asomers@freebsd.org> wrote: > > > >> > > > >> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits <chmeeedalf@gmail.com> > > > wrote: > > > >> > > > > >> > > > > >> > > > > >> > On Sat, Apr 20, 2019, 07:51 Alan Somers <asomers@freebsd.org> wrote: > > > >> >> > > > >> >> Author: asomers > > > >> >> Date: Sat Apr 20 12:51:05 2019 > > > >> >> New Revision: 346441 > > > >> >> URL: https://svnweb.freebsd.org/changeset/base/346441 > > > >> >> > > > >> >> Log: > > > >> >> Use symlinks for kernel modules rather than hardlinks > > > >> >> > > > >> >> When aliasing a kernel module to a different name (ie if_igb for > > > if_em), > > > >> >> it's better to use symlinks than hard links. kldxref will omit > > > entries for > > > >> >> the links, ensuring that the loaded module has the correct name. > > > >> >> > > > >> >> > > > >> > > > > >> > > > > >> > Thanks! This should fix installkernel on my POWER9. > > > >> > > > > >> > - Justin > > > >> > > > >> What's the problem with your POWER9? Is that one of those msdosfs > > > >> /boot systems? If so, I don't think this will fix it. msdosfs > > > >> doesn't support either symlinks or hardlinks. Or is there some other > > > >> problem? > > > >> -Alan > > > > > > > > > > > > Yes it is. Well that's a bummer then. I thought we faked symlinks on > > > msdosfs, but on second thought not sure how well would do that. > > > > > > > > - Justin > > > > > > We should probably just remove the offending links on ppc, then. The > > > only harm is that after upgrading, ppc users would have to replace > > > fuse_load="YES" with fusefs_load="YES". > > > > > > > We should only do the Intel links on those platforms that have legacy users > > that need the old names. We should also only support the old names for one > > release or so. > > IIRC this was done so that the dropping of one of the drivers in ^head > could be merged back to ^stable. It probably should of been killed in > ^head after that fact, but if I recall the values correctly it was > @head=12 and merged to @stable=11. We would need to dig those facts > out, but yes, please, this link should be killed and cleaned up quickly as > it creates almost as many problems as it solved. Ignore most of that I had mixed the other time we did kernel module lnks (intel ethernet driver) with this insance for fuse. Though the principal idea of this should be a short lived compatibility hack still applies. > > Warner > -- > Rod Grimes rgrimes@freebsd.org -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904201915.x3KJFxp3023899>