Date: Wed, 4 May 2022 15:22:00 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Piotr Kubaj <pkubaj@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 Message-ID: <20220504152200.5881461e1e927b155884fe4c@bidouilliste.com> In-Reply-To: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> References: <202205041257.244CvQYJ029723@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 4 May 2022 12:57:26 GMT Piotr Kubaj <pkubaj@FreeBSD.org> wrote: > The branch main has been updated by pkubaj: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ecf09fe3460067b442ba41a6adb85897c99442b5 > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > AuthorDate: 2022-05-04 12:54:19 +0000 > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > CommitDate: 2022-05-04 12:54:19 +0000 > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > amdgpu has known endianness issues and doesn't work on powerpc64. > radeonkms works, while amdgpu works on powerpc64le. > --- > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++---------------- > 2 files changed, 37 insertions(+), 34 deletions(-) > Can you respect MAINTAINER and open a review next time ? Also why doing that at all ? Because if someone wants to work on amdgpu on powerpc64 they now need to revert your commit to have the firmware build. I really don't see a point of doing that. -- Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220504152200.5881461e1e927b155884fe4c>