From owner-freebsd-rc@FreeBSD.ORG Wed Jun 1 00:19:40 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0AD741065670; Wed, 1 Jun 2011 00:19:40 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id B809E8FC0A; Wed, 1 Jun 2011 00:19:39 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id B873B25D385D; Wed, 1 Jun 2011 00:19:38 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id CDC4C159FD4D; Wed, 1 Jun 2011 00:19:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id ZMbmE3daj8cG; Wed, 1 Jun 2011 00:19:36 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 39932159FD45; Wed, 1 Jun 2011 00:19:36 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <4DE55A48.8090508@FreeBSD.org> Date: Wed, 1 Jun 2011 00:19:34 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4DE55A48.8090508@FreeBSD.org> To: Doug Barton X-Mailer: Apple Mail (2.1084) Cc: freebsd-rc@FreeBSD.org Subject: Re: afexists() X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2011 00:19:40 -0000 On May 31, 2011, at 9:14 PM, Doug Barton wrote: Hey, > I don't have any specific objections to this change, although adding = more calls to afexists() highlights an issue I addressed previously in = looking at network.subr. On my system (with IPv6) it's called over 25 = times at each boot, which given that it's a moderately expensive test = indicates an opportunity for optimization. Yeah, it's still a lot cheaper than going into the various = configurations running ifconfigs etc. Especially it does not yield = errors this way;) > Attached is a patch which caches a positive result for support for a = given address family. I don't think caching negative results is a good = idea since that could change as the boot progresses. Not yet for inet or inet6 (or ipx I think) but atm might be loadable. = Looking ahead that's certainly true though maybe also considering = virtualization maybe. >=20 > I plan to commit this on Friday if there are no objections. I am not sure it helps but I see no regression, so if you want, feel = free to go ahead. Bjoern --=20 Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.