From owner-svn-src-head@freebsd.org  Mon Jun 10 07:17:50 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F6BE15B7580;
 Mon, 10 Jun 2019 07:17:50 +0000 (UTC)
 (envelope-from agapon@gmail.com)
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 42F0C95EE6;
 Mon, 10 Jun 2019 07:17:49 +0000 (UTC)
 (envelope-from agapon@gmail.com)
Received: by mail-lj1-f194.google.com with SMTP id 16so6890860ljv.10;
 Mon, 10 Jun 2019 00:17:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt
 :message-id:date:user-agent:mime-version:in-reply-to
 :content-language:content-transfer-encoding;
 bh=YX9hmvLMTUIzf1922UJ/0AFd+ihbS+Y3oCvL+R2YBTQ=;
 b=J1+hmfy/ud4BVTlQ2oMJ3fypu0kTej8789qWH61rVJ2fv3jY3XxEEkWFO3JZo6ZXFc
 ax44e7vJ7dJLwsQSnMddLffAw1CoeNe9BjmH6Gk0as1EBwUcF+PN0KJCFlnCLHbOGv8T
 1GhR1Ks9Aee/HZGCVDkcKp4gkV+TQp+6Tqn7YSsbu9QJexZlEAwv0/DnXCxgwYig+ljd
 9JFnBKhCiTxNdkUZ0N+f83qOMg8qu136h7QWCmJlYZZu56h0ZsOuBwzzfVianm/oA7Rw
 QuUq2MappfXUNPTrLn9ZGNV5bjUmz/kPNxDAiilznqLdE0JIY3xN+rsUfSQ7eTM8CDqe
 Ql3w==
X-Gm-Message-State: APjAAAUiwzSRROS+QSE4LJOqJsJq+ea6z1QY9c0s/wR4ciioyb8KNCjS
 UCOzSDBWQgyZh7ye4pDKNfL9tvv1
X-Google-Smtp-Source: APXvYqw4FqxS0H2DdCMCh7r1ZqJ2Y/D3MbgtrIvtmY/iT5qRa0pDhIUcoAR+2zn4H92utt16ny3krg==
X-Received: by 2002:a2e:8696:: with SMTP id l22mr11995757lji.201.1560151067448; 
 Mon, 10 Jun 2019 00:17:47 -0700 (PDT)
Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96])
 by smtp.googlemail.com with ESMTPSA id g15sm1780925ljk.83.2019.06.10.00.17.45
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 10 Jun 2019 00:17:46 -0700 (PDT)
Subject: Re: svn commit: r348843 - head/sys/vm
To: Doug Moore <dougm@rice.edu>, Doug Moore <dougm@FreeBSD.org>,
 src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
References: <201906100307.x5A37BFt099669@repo.freebsd.org>
 <c54a0e35-d5c6-0711-d2bb-01e3dca802c3@FreeBSD.org>
 <21baf615-3356-73a1-52b0-d2f33f4cf49d@rice.edu>
From: Andriy Gapon <avg@FreeBSD.org>
Openpgp: preference=signencrypt
Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata=
 xsFNBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7
 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l
 N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z
 AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i
 gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ
 /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4
 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8
 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS
 ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx
 rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABzR5BbmRyaXkgR2Fw
 b24gPGF2Z0BGcmVlQlNELm9yZz7CwZQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC
 WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV
 l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL
 rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO
 LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj
 GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/
 QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT
 eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/
 psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o
 JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R
 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H
 lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryM7BTQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW
 be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+
 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY
 EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO
 jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye
 syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m
 WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI
 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+
 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN
 MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L
 HgZY3zfKOqcAEQEAAcLBfAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM
 BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i
 ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs
 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR
 XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk
 LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4
 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym
 dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6
 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0
 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx
 NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp
Message-ID: <bf8f80a0-4de9-dd98-6063-664a04973971@FreeBSD.org>
Date: Mon, 10 Jun 2019 10:17:44 +0300
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <21baf615-3356-73a1-52b0-d2f33f4cf49d@rice.edu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: 42F0C95EE6
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.98 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.98)[-0.980,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Jun 2019 07:17:50 -0000

On 10/06/2019 09:42, Doug Moore wrote:
> -fwrapv concerns signed arithmetic.  This calculation is with unsigned
> arithmetic, and the possibility of wrapping around to 0 is part of the
> language.

Oh, sorry for the noise!

> On 6/10/19 1:35 AM, Andriy Gapon wrote:
>> On 10/06/2019 06:07, Doug Moore wrote:
>>> Author: dougm
>>> Date: Mon Jun 10 03:07:10 2019
>>> New Revision: 348843
>>> URL: https://svnweb.freebsd.org/changeset/base/348843
>>>
>>> Log:
>>>   There are times when a len==0 parameter to mmap is okay. But on a
>>>   32-bit machine, a len parameter just a few bytes short of 4G, rounded
>>>   up to a page boundary and hitting zero then, is not okay. Return
>>>   failure in that case.
>>>   
>>>   Reported by: pho
>>>   Reviewed by: alc, kib (mentor)
>>>   Tested by: pho
>>>   Differential Revision: https://reviews.freebsd.org/D20580
>>>
>>> Modified:
>>>   head/sys/vm/vm_mmap.c
>>>
>>> Modified: head/sys/vm/vm_mmap.c
>>> ==============================================================================
>>> --- head/sys/vm/vm_mmap.c	Sun Jun  9 22:55:21 2019	(r348842)
>>> +++ head/sys/vm/vm_mmap.c	Mon Jun 10 03:07:10 2019	(r348843)
>>> @@ -257,7 +257,10 @@ kern_mmap(struct thread *td, uintptr_t addr0, size_t s
>>>  
>>>  	/* Adjust size for rounding (on both ends). */
>>>  	size += pageoff;			/* low end... */
>>> -	size = (vm_size_t) round_page(size);	/* hi end */
>>> +	/* Check for rounding up to zero. */
>>> +	if (round_page(size) < size)
>> Is this guaranteed to work with all compilers?
>> I think that some smart compilers may think that this condition is impossible.
>> Are we finally using -fwrapv or something like it for kernel builds?
>>
>>> +		return (EINVAL);
>>> +	size = round_page(size);		/* hi end */
>>>  
>>>  	/* Ensure alignment is at least a page and fits in a pointer. */
>>>  	align = flags & MAP_ALIGNMENT_MASK;
>>>
>>


-- 
Andriy Gapon