From owner-svn-src-all@freebsd.org Wed Jul 8 22:12:06 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9EF0996720; Wed, 8 Jul 2015 22:12:06 +0000 (UTC) (envelope-from zbodek@gmail.com) Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [IPv6:2a00:1450:4010:c03::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3015D364D; Wed, 8 Jul 2015 22:12:06 +0000 (UTC) (envelope-from zbodek@gmail.com) Received: by lagx9 with SMTP id x9so234502313lag.1; Wed, 08 Jul 2015 15:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=mJr9buF2G0G46+Kx3zciUZ0zszKnpBEafMX0ARwkZpI=; b=z7k3uGbkEAEfgJ7VF+DW+Uo/YpNFHGEdPVE0pnwVqe/oiPh/c5fhsuWoQrBnpy/TW4 Npxbm0EtWUFIn7I9V/YdkdnOn2jtnvHy36WjZTNSD41Enrgx/VNLxLkZtFES+1f0qDa5 BlsByov73thinbRtrlFmjZKhLzpuceJbhPAogrL+IxAzKwGEjs85tDyxwvM2Yl//3cUU cRGrvhq++3rU1RPrn2LtycJ/mrzgMjoeXTLGBxak5VSk3dW/by3pKw3y1ByQToLfiWhS kek8YhwMOS6txRw1dPZ3Lp6F76fQOoTkY2ZrIyGIq/gjnHT99I1sr3miCeOV/qT6n2lX O98w== X-Received: by 10.112.201.199 with SMTP id kc7mr11733586lbc.25.1436393524314; Wed, 08 Jul 2015 15:12:04 -0700 (PDT) MIME-Version: 1.0 Sender: zbodek@gmail.com Received: by 10.112.55.42 with HTTP; Wed, 8 Jul 2015 15:11:44 -0700 (PDT) In-Reply-To: <20150708194708.GQ8523@funkthat.com> References: <201507081353.t68Dr0up028388@repo.freebsd.org> <20150708194708.GQ8523@funkthat.com> From: Zbigniew Bodek Date: Thu, 9 Jul 2015 00:11:44 +0200 X-Google-Sender-Auth: Z1uBzh4oLqFcX8JLKXTQy8xADHo Message-ID: Subject: Re: svn commit: r285270 - head/sys/sys To: John-Mark Gurney Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 22:12:06 -0000 Hello, You are absolutely right. Especially semicolons... I must have missed this somehow. Thanks. Fixed in r285293. Best regards zbb 2015-07-08 21:47 GMT+02:00 John-Mark Gurney : > Zbigniew Bodek wrote this message on Wed, Jul 08, 2015 at 13:53 +0000: >> +#if defined(__arm__) >> + #define __BUS_DMAMAP_SYNC_DEFAULT mb(); >> +#elif defined(__aarch64__) >> + #define __BUS_DMAMAP_SYNC_DEFAULT dmb(sy); > > These shouldn't have ; after them... > >> +#else >> + #define __BUS_DMAMAP_SYNC_DEFAULT {} > > The correct spelling of this should probably be: > do { } while (0) > >> +#endif >> #define bus_dmamap_sync(dmat, dmamap, op) \ >> do { \ >> if ((dmamap) != NULL) \ >> _bus_dmamap_sync(dmat, dmamap, op); \ >> + else \ >> + __BUS_DMAMAP_SYNC_DEFAULT \ > > And then this can be properly written w/ a ; at the end... > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not."