From nobody Thu Sep 18 22:08:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cSVBb4SFbz686Xv; Thu, 18 Sep 2025 22:08:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cSVBb3t0Yz3kND; Thu, 18 Sep 2025 22:08:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758233287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SQDsmDLhb+Hxo/DoTzCidGt59sSMMVf1jW7pUA62rWY=; b=Jyw2TdoAF5apWlK7c1bSEBE8TUkCehO51mX+xHHi60pJ9Wi/Nol8g1MhpBh1u4kKyJgJMD x8dX/TjfVv3+loglpXsTKrMG32MsCjZXAy0MK8Xkk4tJYz9mRcFMYWxavJcXp0bMTVfX7R 5+Hgg92EwAoicomagA77yJL/KC8A6BC7IVMLEYe7yIfuFVL+b1CvuB14a0ey28dCJTQ1K3 k9CesqLWlBzQBL1B5NgEhhMbHcps/4ZxG264R6Uci7TEq1ByAA+xF4dEJqAe2XZI3zyTG/ PfU4sT6NUgVpUl9PW2tHqW9rr8IHoWlGiCXiOq4yPOmn49m/sct/jpoJzxkJvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758233287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SQDsmDLhb+Hxo/DoTzCidGt59sSMMVf1jW7pUA62rWY=; b=i0v6QnXHc7S8OQHlwgdurRr0Pu0pROdzYd8H93CW1qmIeHFMsBGpydlYIThPIqgyWUjJ75 nwuaVYjifshpwhfbYTuTenLHpEy6HeEmn/nz6IixxhJ6/pDVds9xbI5Igp4C+VTEuis3kL ySjZGiViYFTk838V0zBE6DaNAO+uoYbDqINiRR7zXKlMGa6HAo93uiZN3pMgqKSB2pmtJG lVQRRCCjIipaLGm+r2Dfed1Q3obiKv9HyCLFIW32HwwlVagFdO53A4FROpql8k4tGJIS+n SmKhKjlXILqbzWz9Qevez95MOSk6ZN9EOd80J7j7hojXHSc76loZL7A6DAnPOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758233287; a=rsa-sha256; cv=none; b=fhYYV7A2hBZpLoaANl7a6LS4Dc0bCe1C9usSriqhnytf8P6+3u1HpRHit2r4Df2yA4Dwg8 5fIbaubU8EyS5zlU1ItQvdpE+5rGVtvqEJ0YiIkEe0L1aIb9ZNgxuEY4IQGeho9YE2TPss 3+rpMuMFN/uVeXo1/1RnwkcYCuTYkLjhXy/Sm7B46xIiyrn+0ZhubpFtOo2d7Y4lFOpKRE ZheMD3Kw9XpP+w6URS5iUmyARwfYJdFmpdBCGVwH/DXBK0U9TrmyiSI3VDKI/XGZXA5Y7m Eed63ZmakkNa7UG3NJI8QIEMeNaUl8A/z3LPBDsPKCoMxTq8rZpPSLY7rnr5Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cSVBb3QRGzTt8; Thu, 18 Sep 2025 22:08:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58IM87tl007811; Thu, 18 Sep 2025 22:08:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58IM87fG007808; Thu, 18 Sep 2025 22:08:07 GMT (envelope-from git) Date: Thu, 18 Sep 2025 22:08:07 GMT Message-Id: <202509182208.58IM87fG007808@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: e0c83ab3b362 - main - gpioled: remove redundant -1 check List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e0c83ab3b362c9bd45c5d21683012cecab28d802 Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=e0c83ab3b362c9bd45c5d21683012cecab28d802 commit e0c83ab3b362c9bd45c5d21683012cecab28d802 Author: Ahmad Khalifa AuthorDate: 2025-09-18 22:03:32 +0000 Commit: Ahmad Khalifa CommitDate: 2025-09-18 22:06:37 +0000 gpioled: remove redundant -1 check The function is never called with onoff = -1 MFC after: 3 days MFC with: 9ae3c30 --- sys/dev/gpio/gpioled.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/gpio/gpioled.c b/sys/dev/gpio/gpioled.c index 71af5741b2fe..a36c2faef379 100644 --- a/sys/dev/gpio/gpioled.c +++ b/sys/dev/gpio/gpioled.c @@ -75,8 +75,6 @@ gpioled_control(void *priv, int onoff) struct gpioled_softc *sc; sc = (struct gpioled_softc *)priv; - if (onoff == -1) /* Keep the current state. */ - return; if (sc->sc_softinvert) onoff = !onoff; GPIOLED_LOCK(sc);