From owner-svn-ports-all@FreeBSD.ORG  Wed Apr 15 18:04:32 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B2262AB7;
 Wed, 15 Apr 2015 18:04:32 +0000 (UTC)
Received: from mailrelay102.isp.belgacom.be (mailrelay102.isp.belgacom.be
 [195.238.20.129])
 by mx1.freebsd.org (Postfix) with ESMTP id D83DD816;
 Wed, 15 Apr 2015 18:04:31 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-Cloudmark-SP-Filtered: true
X-Cloudmark-SP-Result: v=1.1 cv=+BsAzE94k0WpM8AtezFGaEXBVpw1lpSE4R7UN5Nfg4g=
 c=1 sm=2
 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=MxoXZ1MMpQsy8t0UebMA:9 a=CjuIK1q_8ugA:10
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2DVDACGpi5V/zOwsFtcgwxSUAzHSIYDAoE6TQEBAQEBAX5BBYNbAQEEOhwjEAsOBgQJJQ8qHgYTiC4BCMRkAQEBAQEBAQEBAQEBAQEBAQEXBIsrhHwHhC0BBJURhhyBHoxOhw4ig3E8MYJDAQEB
Received: from 51.176-176-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.176.176.51])
 by relay.skynet.be with ESMTP; 15 Apr 2015 20:03:17 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id t3FI3FkV021480;
 Wed, 15 Apr 2015 20:03:15 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Wed, 15 Apr 2015 20:03:14 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Mikhail Teterin <mi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r384031 - in head/net/libsrtp: . files
Message-ID: <20150415200314.0593427b@kalimero.tijl.coosemans.org>
In-Reply-To: <201504142224.t3EMOiuf041928@svn.freebsd.org>
References: <201504142224.t3EMOiuf041928@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2015 18:04:32 -0000

On Tue, 14 Apr 2015 22:24:44 +0000 (UTC) Mikhail Teterin <mi@FreeBSD.org> wrote:
> Author: mi
> Date: Tue Apr 14 22:24:44 2015
> New Revision: 384031
> URL: https://svnweb.freebsd.org/changeset/ports/384031
> 
> Log:
>   Only use -fPIC, when compiling shared objects, not static ones.

You should be careful with changes like this.  In my opinion this should
be discussed and decided upstream and not in a port.  I'm working on an
update of mediastreamer (and linphone) and it wants to link libsrtp.a
into a shared library under some conditions.  These conditions don't
apply to us, but it does show that there might be code out there that
expects libsrtp.a to be compiled with -fPIC.

There are a number of ports that blindly add -fPIC to CFLAGS and I'm all
for removing that or adding comments explaining why it's necessary, but
when upstream compiles static libraries with -fPIC I don't think we
should change that.