From owner-cvs-all@FreeBSD.ORG Wed Oct 31 22:49:10 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3421416A420; Wed, 31 Oct 2007 22:49:10 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 9C5B413C4B2; Wed, 31 Oct 2007 22:49:09 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9VMmKTC091322; Thu, 1 Nov 2007 01:48:20 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193870900; bh=Vw5whkwvO3QfGd/s1nOcqYXJCHXgLXi5/6H40FJ q0AQ=; l=921; h=Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent; b=UILqfmQiVwjO42kyXfAI2Ne7EZJVBo03HPG9FO4A Coh0vBpNcSmbkPSTp18bEWDK1FoOihlrRIa0XILuUAdP8GKNiHEbcOrbGVt4pKWExE1 0jVBm0jwiie4pgnFOCUUlUlDc4AlM2E0sk2I9A0XIJC0zxe/e2E7K5BnWJHF3fBQ= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9VMmK75091321; Thu, 1 Nov 2007 01:48:20 +0300 (MSK) (envelope-from ache) Date: Thu, 1 Nov 2007 01:48:19 +0300 From: Andrey Chernov To: Juli Mallett Message-ID: <20071031224818.GA91246@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Juli Mallett , Alexey Dokuchaev , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200710272232.l9RMWSbK072082@repoman.freebsd.org> <20071030200331.GA29309@toxic.magnesium.net> <20071031215526.GC89932@nagual.pp.ru> <20071031223349.GA552@FreeBSD.org> <20071031223727.GB90994@nagual.pp.ru> <20071031224313.GA18285@toxic.magnesium.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071031224313.GA18285@toxic.magnesium.net> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.ORG, Alexey Dokuchaev , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/include _ctype.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2007 22:49:10 -0000 On Wed, Oct 31, 2007 at 12:43:13PM -1000, Juli Mallett wrote: > > 1. Reader-friendly version generates long code when absolutely no > > optimization used in compiler (for some reason f.e. to avoid optimization > > bugs). > > So if someone is trying to avoid compiler optimization bugs we should subject > them to human optimization bugs instead? :) Not sure I understand your motto. There is no human optimization bugs, just attempt to save what we can to save when no optimization (or another non-smart compiler) is used. > > 2. It also breaks common style ctype using for is{w}ascii(). If revert > > this, is{w}ascii() should be rewritted too. > > That seems reasonable. Well, I don't want to fight here. If there general consensus that we should prefer human-readable code for __isctype(), isascii() and iswascii() in trade for some edge cases, let it be so. -- http://ache.pp.ru/