From owner-freebsd-arch@FreeBSD.ORG  Tue Jul  9 20:15:40 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 8FA18335;
 Tue,  9 Jul 2013 20:15:40 +0000 (UTC)
 (envelope-from rmh.aybabtu@gmail.com)
Received: from mail-qc0-x22b.google.com (mail-qc0-x22b.google.com
 [IPv6:2607:f8b0:400d:c01::22b])
 by mx1.freebsd.org (Postfix) with ESMTP id 46ECB19E9;
 Tue,  9 Jul 2013 20:15:40 +0000 (UTC)
Received: by mail-qc0-f171.google.com with SMTP id n1so3280742qcw.30
 for <multiple recipients>; Tue, 09 Jul 2013 13:15:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=pwfp/TdxAcH2OzNkEHniJWMvm85ADAgzvuMzKsrvD0o=;
 b=GT6R7DbhoNmdl30LCLODKxPz7Iq7TFhA7d7Qv9HpZ9sIiz+dPLuYslP9V0VfIRiA+7
 Gky0e+BV7JAmEzDPkskAhM9963MQRcP99kiziUm6Tu2PtAVWF+CUg8Pend6pk0hywXZm
 Hs1VKpS9oY6F5mPkSK3U8HoHgXeVBnm4SDZKGdZF/bZgSp0bzNg8SxzkAEx94Hmc4rrX
 qC8B95z+XDCxMMvW6mTR3D9elTIRpgUj8oVivsdqhCUjzq2atb2l/jxUdQEqOgkYp8Jn
 FKvklURoUy77sgkyRsrXMsL5Gg5QsFj7gPEsnpH0afaMq9liC9SsVJ6wF/viDlKTg0Br
 yHcw==
MIME-Version: 1.0
X-Received: by 10.224.98.140 with SMTP id q12mr24863469qan.99.1373400939807;
 Tue, 09 Jul 2013 13:15:39 -0700 (PDT)
Sender: rmh.aybabtu@gmail.com
Received: by 10.49.26.193 with HTTP; Tue, 9 Jul 2013 13:15:39 -0700 (PDT)
In-Reply-To: <20130709185846.GA19508@gmail.com>
References: <CAOfDtXPT-BQt9aqTNYHRK0XdiqKZsPnsO6s9vei=XCpyBvZZ6w@mail.gmail.com>
 <20130709185846.GA19508@gmail.com>
Date: Tue, 9 Jul 2013 22:15:39 +0200
X-Google-Sender-Auth: B11NHq5Cg-C2H12VGl1hQ-B9YgM
Message-ID: <CAOfDtXMC_q3MSV3-wYCRj=mtQ0F5e_ZiqccF3RUA4F4BHKmfYw@mail.gmail.com>
Subject: Re: ABI change in libkvm (kvm_uread removal)
From: Robert Millan <rmh@freebsd.org>
To: Mikolaj Golub <trociny@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-arch@freebsd.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jul 2013 20:15:40 -0000

2013/7/9 Mikolaj Golub <trociny@freebsd.org>:
> I think I thought then that kvm_uread() was for internal usage only
> (it was used by libkvm only for reading process args and env via
> procfs(5), no other consumers were found in base, no man page). Also
> reading from procfs(5) did not look like libkvm job, so after the last
> consumers had been removed, retiring it looked natural. I think I
> overlooked the declaration in kvm.h and that I might break ABI,
> otherwise it would have made me think more and ask other people if the
> removal was ok.

Well I have no need for kvm_uread myself. In fact I don't even know
what it does ;-)

The ABI change was detected by Debian build tools during our upgrade
to FreeBSD 9.1 codebase, which just means we will have to bump the
soname.

That is, unless you're planning to bring kvm_uread back?

>> Should kvm.h and Makefile be adjusted to reflect the new ABI?
>
> Suggestions how this should be fixed properly (if possible) are highly
> appreciated. I will do what people suggest.

If noone else wants it, I'd suggest to bump soname, MFC, and be done with it.

--
Robert Millan