From owner-freebsd-current@FreeBSD.ORG Mon Jan 17 00:51:38 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F6F416A4CE; Mon, 17 Jan 2005 00:51:38 +0000 (GMT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id A1B0C43D2D; Mon, 17 Jan 2005 00:51:37 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j0H0pa77015260; Sun, 16 Jan 2005 19:51:36 -0500 Mime-Version: 1.0 Message-Id: In-Reply-To: References: Date: Sun, 16 Jan 2005 19:51:35 -0500 To: Robert Watson , "David O'Brien" From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) cc: freebsd-current@freebsd.org Subject: Re: gratuitous gcc warnings: unused function arguments? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2005 00:51:38 -0000 At 9:05 PM +0000 1/16/05, Robert Watson wrote: >On Sun, 16 Jan 2005, David O'Brien wrote: > > > We're not going to hack GCC to deal with this. That is going way > > too far. This is coming up because people are using high WARNS > > values in Makefiles. Either back them down to a lower WARNS value; > > or we should add -Wno-unused-parameter to WARNS level 3. > >I'd be fine with simply pushing threshold for unused parameters up >a few notches on the warning scale. I'd like to have access to the >other interesting warnings are WARNS=3 and WARNS=4 relating to >qualifiers, strings, etc. I think it would be useful to keep that warning "in general", but have an option to turn it off. The following seems to work for me, assuming we can decide on the best name for a new NO_WUNUSED_ARGS option: Index: bsd.sys.mk =================================================================== RCS file: /usr/cvs/free/depot/src/share/mk/bsd.sys.mk,v retrieving revision 1.35 diff -u -r1.35 bsd.sys.mk --- bsd.sys.mk 12 Mar 2004 21:36:12 -0000 1.35 +++ bsd.sys.mk 17 Jan 2005 00:32:14 -0000 @@ -29,6 +29,9 @@ . if ${WARNS} > 5 CWARNFLAGS += -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls . endif +. if defined(NO_WUNUSED_ARGS) && ${WARNS} < 5 +CWARNFLAGS += -Wno-unused-parameter +. endif . if ${WARNS} > 1 && ${WARNS} < 5 # XXX Delete -Wuninitialized by default for now -- the compiler doesn't # XXX always get it right. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu