From owner-freebsd-current@FreeBSD.ORG Fri Feb 22 10:20:35 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3526016A408 for ; Fri, 22 Feb 2008 10:20:35 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.175]) by mx1.freebsd.org (Postfix) with ESMTP id 05D9D13C459 for ; Fri, 22 Feb 2008 10:20:34 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wf-out-1314.google.com with SMTP id 25so212254wfa.7 for ; Fri, 22 Feb 2008 02:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=hY8GYL4Q1Y9HeXI1he4ZoDpKW5rIyxlC0ttpxWwfSqM=; b=xbcNLrrcRADS1lMBzzh/di62YjiprxRUvEMhpRf5Y4Mf8PFljyK+28SzZkG8Q3lfWgPM/ct1MnJP7DCtzRJqmmBMgK8IlGag8sNj7QG+vObDp6p1lwM3o7qpeQtpUb54zNJQkN/CRd5usBxjfgEFswLv3yk+C/Sza6pUBnIUAks= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=vQDfYrOgj0f4DIWjvYqusU8aW4Wdu79ioFXLd1C9ucskcf8+iCvVnVnov3E09jBOb6b7rqnPco+i5cjOMO/CLJFaG9eGoIIX2q8JWsyFaXe3c1lVcZSyqVGbD+YkpSTHpO4MfeVbq+9vBuiLvu91CKQnworLyaJEQOnZJ1WmXRg= Received: by 10.142.158.17 with SMTP id g17mr8518594wfe.127.1203675634666; Fri, 22 Feb 2008 02:20:34 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id 22sm2076237wfi.12.2008.02.22.02.20.31 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Feb 2008 02:20:33 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id m1MAKRGq032537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Feb 2008 19:20:27 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id m1MAKQM5032536; Fri, 22 Feb 2008 19:20:26 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Fri, 22 Feb 2008 19:20:26 +0900 From: Pyun YongHyeon To: Ian FREISLICH Message-ID: <20080222102026.GH30497@cdnetworks.co.kr> References: <20080222042700.GB30497@cdnetworks.co.kr> <20080222094742.GF30497@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="vGgW1X5XWziG23Ko" Content-Disposition: inline In-Reply-To: <20080222094742.GF30497@cdnetworks.co.kr> User-Agent: Mutt/1.4.2.1i Cc: FreeBSD Current , Robert Backhaus Subject: Re: Packet corruption in re0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2008 10:20:35 -0000 --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 22, 2008 at 06:47:42PM +0900, To Ian FREISLICH wrote: [...] > > It seems like it's corrupting large packets on transmit when vlanhwtag > > is enabled. From the tcpdump output it looks like a padding or > > packet length issue. > > > > Here's what tcpdump on the re(4) device thinks it's transmitting: > > > > 00:08:a1:3c:32:9c > 00:90:fb:0c:89:7d, ethertype 802.1Q (0x8100), length 1510: vlan 1000, p 0, ethertype IPv4, 196.22.138.92 > 196.22.138.89: OSPFv2, Database Description, length: 1472 > > > > Here's what was actually recieved by the em(4) device on the > > neighbour. Note the absense of the 801.1Q header: > > > > I see, I'll check it. > > > 00:08:a1:3c:32:9c > 00:90:fb:0c:89:7d, ethertype IPv4 (0x0800), length 1506: 196.22.138.92 > 196.22.138.89: OSPFv2, Database Description, length: 1472 > > > > When vlanhwtagging is disabled, the re(4) device transmits: > > > > 00:90:fb:0c:89:7d > 00:08:a1:3c:32:9c, ethertype 802.1Q (0x8100), length 1510: vlan 1000, p 0, ethertype IPv4, 196.22.138.89 > 196.22.138.92: OSPFv2, Database Description, length: 1472 > > > > and the em(4) device recieves: > > > > 00:08:a1:3c:32:9c > 00:90:fb:0c:89:7d, ethertype 802.1Q (0x8100), length 1510: vlan 1000, p 0, ethertype IPv4, 196.22.138.92 > 196.22.138.89: OSPFv2, Database Description, length: 1472 > > > > Let me know if you need more detailed tcpdump output than I've provided. > > Apply attached patch and let me know how it goes. It just disables checksum offload for vlan interface. -- Regards, Pyun YongHyeon --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="re.vcsum.patch" Index: if_re.c =================================================================== RCS file: /home/ncvs/src/sys/dev/re/if_re.c,v retrieving revision 1.103 diff -u -r1.103 if_re.c --- if_re.c 17 Jan 2008 23:37:47 -0000 1.103 +++ if_re.c 22 Feb 2008 10:16:26 -0000 @@ -1332,8 +1332,10 @@ /* VLAN capability setup */ ifp->if_capabilities |= IFCAP_VLAN_MTU | IFCAP_VLAN_HWTAGGING; +#if 0 if (ifp->if_capabilities & IFCAP_HWCSUM) ifp->if_capabilities |= IFCAP_VLAN_HWCSUM; +#endif ifp->if_capenable = ifp->if_capabilities; #ifdef DEVICE_POLLING ifp->if_capabilities |= IFCAP_POLLING; --vGgW1X5XWziG23Ko--