From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:54:47 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 950BC1065679; Tue, 16 Feb 2010 19:54:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 05F558FC14; Tue, 16 Feb 2010 19:54:46 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o1GJsfQ8003367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Feb 2010 21:54:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id o1GJsfcl027520; Tue, 16 Feb 2010 21:54:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id o1GJse0V027519; Tue, 16 Feb 2010 21:54:40 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 16 Feb 2010 21:54:40 +0200 From: Kostik Belousov To: Attilio Rao Message-ID: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+SfteS7bOf3dGlBC" Content-Disposition: inline In-Reply-To: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: FreeBSD Arch , Ed Maste Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:54:47 -0000 --+SfteS7bOf3dGlBC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > The following patch: > http://www.freebsd.org/~attilio/x86.diff >=20 > starts the effort for having a shared sub-tree between amd64 and ia32. > In this initial pass I putted the low-hanging fruits (bios/cpufreq) > and what my customer was more interested in (isa/*) in order to > kick-off the effort and, in the future, move gradually the code there. > With the machine/isa/* cleanup about 10 files are trimmed and I'm sure > more can be achieved easilly. > There are few things to discuss. One, that I had not necessity to dig > about still, is about how to organize headers (include/). Maybe some > replication ala pc98 may be good. >=20 > The patch is big but it is mostly added and removed files (look at the > files.X in order to understand better how files movements happened). >=20 > Hope to see comments and reviews. IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) operation now, without a review, and post a diff that should be applied to x86/ directory, as well as to build glue. The small proposition I have is to #define read_eflags() read_rflags() for amd64. --+SfteS7bOf3dGlBC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkt6+AAACgkQC3+MBN1Mb4hqbACbBB+fo9TKiGOMcOtyEaOkmeMN IEQAoMXiY3VwVWi5HJinqBGQWtPOWMYp =g2EY -----END PGP SIGNATURE----- --+SfteS7bOf3dGlBC--