From owner-freebsd-hackers@FreeBSD.ORG  Thu May 10 15:17:56 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 361C0106564A;
	Thu, 10 May 2012 15:17:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 03AE68FC15;
	Thu, 10 May 2012 15:17:56 +0000 (UTC)
Received: from John-Baldwins-MacBook-Air.local (unknown [192.75.139.252])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5CB85B968;
	Thu, 10 May 2012 11:17:55 -0400 (EDT)
Message-ID: <4FABDC23.2090400@FreeBSD.org>
Date: Thu, 10 May 2012 11:17:55 -0400
From: John Baldwin <jhb@FreeBSD.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
	rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Andriy Gapon <avg@FreeBSD.org>
References: <4F8999D2.1080902@FreeBSD.org> <201205070953.04032.jhb@freebsd.org>
	<4FA7E069.8020208@FreeBSD.org> <201205071343.45955.jhb@freebsd.org>
	<4FA8C7E3.8070006@FreeBSD.org> <4FA92A88.2030000@FreeBSD.org>
	<4FA96747.3060106@FreeBSD.org> <4FAA3994.2070701@FreeBSD.org>
	<4FAA54C1.20203@FreeBSD.org> <4FAB8D31.8050301@FreeBSD.org>
In-Reply-To: <4FAB8D31.8050301@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Thu, 10 May 2012 11:17:55 -0400 (EDT)
Cc: freebsd-hackers@FreeBSD.org, Takahashi Yoshihiro <nyan@FreeBSD.org>
Subject: Re: bootargs.h
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 May 2012 15:17:56 -0000

On 5/10/12 5:41 AM, Andriy Gapon wrote:
> on 09/05/2012 14:28 John Baldwin said the following:
>> On 5/9/12 5:32 AM, Andriy Gapon wrote:
>>>
>>> Here is a subversion diff to make use of the new bootargs.h header in pc98
>>> cdboot and loader, and i386 cdboot and pxeldr:
>>> http://people.freebsd.org/~avg/bootargs.diff
>>> Could you please review it?
>>> Thank you!
>>
>> Looks good.
>>
>>> MFi386 of BTX changes for support of KARGS_FLAGS_EXTARG is pending.
>>> Do you think that it should be done?
>>
>> You mean to pc98's btxldr?  I think so, in general we should keep the
>> pc98 BTX bits as close to i386 as possible.
>>
> 
> Yes.  Here is a complete pc98 patch for bootargs.h and btxldr:
> http://people.freebsd.org/~avg/pc98-btxldr.diff

Looks ok to me.  We should really see about letting PC98 share more code
here rather than using copies if it's not too ugly.

-- 
John Baldwin