From owner-svn-src-all@freebsd.org Fri Jan 18 00:55:08 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 24EE214873CD for ; Fri, 18 Jan 2019 00:55:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AF8258EDF2 for ; Fri, 18 Jan 2019 00:55:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x843.google.com with SMTP id p17so13545081qtl.5 for ; Thu, 17 Jan 2019 16:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PR3u1wr566KY7MQkkxUo7MWbtVG3BC78LZ12uiAS1SE=; b=pIdxLxue1wm6F+xQfDIWL7heHo9L02Lm6DNMr5I5W2BrihVZ74bjzT0Q0ZvcKt6Z1i xWt3k5zBpq5roMTgW0J9timOBTc+4e3Q8NN74BsYSHUn2EpaAwpIgUtjmIYUsBnBNzOm gkVG6xysYK9vx8mgy+CQCsWJRNoDVj7fZ0J0qGVaNDI1PAq882rQ0JFmJ46sZtQg1Bv9 qgUGoxrwdJYmSakBnUsneS01OafaE88lUZRiNICQEtS1vKRqqRjJlGWiyFE2SwJri65d eTQ0jMSAu/FCnlxrKPH1a1jxbEaULye2gzsf69pkAOoPQDSaA/uHH+CVyO603cxVQl9d DCAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PR3u1wr566KY7MQkkxUo7MWbtVG3BC78LZ12uiAS1SE=; b=NtEZDdL+ClTCvvmfI5Y1kYtzRkKAFez+A04eRLD/bambBnkNK0sNhpz+vaT2S/PaIv FJVq1DE3FR1xFuj6UcuHZGxjwVJ3LaCzqgdPmeK3eOAevBLupSHnhmYkE+DRjkjVdQ2X pz4IRFR1O69jVcsU+qblQrV6dYeof9Ajj41KP5vhNA4WbZcX3AcMdHI/r0HOfQ0/PxCy gCdD+0TDLNjeNs7p0zTm63GOtzPHmerTCZIluXq9buAJI8peWpsvzROAQXIUdx1LXFPR QCRYe96itmUbI2ZTq2C1HQm9wjdsDWl1j3Bhvwc9mzeHZjRzqu9IDi4ngeWm9ZeBYegP V1jQ== X-Gm-Message-State: AJcUukcdUVSknyHNt1LnWkFbnHV5h3JEGM3Oaf+Jd4Gi5CffOuUYMpF2 rmhsWkAY4boGiOU6ZW4WxtT1QV9GG5xk8khzQlkxZA== X-Google-Smtp-Source: ALg8bN5lWRv1uXJgmldsa0ZMwTe9PlLrF/i3ORvT7ZJoYFemoWW/mOa0X/qSQgsEySZhzPgu4w2e+lp1cduAudG2DEk= X-Received: by 2002:ac8:42c1:: with SMTP id g1mr14016764qtm.118.1547772907060; Thu, 17 Jan 2019 16:55:07 -0800 (PST) MIME-Version: 1.0 References: <201901180048.x0I0mois052935@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201901180048.x0I0mois052935@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Thu, 17 Jan 2019 17:54:56 -0700 Message-ID: Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim To: "Rodney W. Grimes" Cc: "Conrad E. Meyer" , Eugene Grosbein , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: AF8258EDF2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 00:55:08 -0000 On Thu, Jan 17, 2019 at 5:48 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > > > > > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein > wrote: > > > > > > > > 18.01.2019 3:23, Conrad Meyer ?????: > > > > > > > > > Please back it out; stop attributing code review to "hackers@," > which > > > > > can not (it's a list, not individuals) and did not review this > > > > > changeset; and put it on phabricator for actual review. > > > > > > > > There is already https://reviews.freebsd.org/D18380 by imp > > > > and there were over 6 weeks since it had an update. > > > > Newly committed code has most of its changes. > > > > > > Your response does not address *any* of the above concerns. It's just > > > unrelated. > > > > > > > Yes. > > > > > > > The review you linked to isn't one you submitted for this change; it's > > > Warner's, and that one stalled because you were such a jerk to him > > > last time that he needed time off from you. > > > > > > > I abandoned it because dd is the better way to go because it can transfer > > images with 0's and TRIM the zero'd pages (and only the zero'd pages). > Sure > > dd is hard to use, but it's not that hard to use. > > I strongly disagree that dd is the proper place for this tool, > dd is far to easy a way to destroy data when trying to do this > type of operation and should be the last choice for implementing > what is normally a very safe thing to do. > > And as eugene points out dd can not easily be made > to do "trim ada0 ada1 ada4" which is probably the > far more common use of this command > for i in ada0 ada1 ada4; do dd of=/dev/$i if=/dev/zero conv=trim &; done; wait if that's your objection. It's a weak counter argument, but this really isn't the place for the debate. > dd's ability to do sparse(ing) of a file should NOT be > overloaded with a device layer block trimming function. > It's not overloaded. You have to specifically ask for the conversion. It's the right place for it. > > > > > > > If you want to socialize, revive, or expedite someone else's review, > > > maybe add a new comment to the review, or post a discussion hackers@, > > > or something like that. You still can't attribute code review to > > > hackers@, especially as no such review happened. > > > > > > > I think it should be backed out. Especially since it hijacks my work and > my > > name to try to ram it into the tree. > > > > I'm very much not amused. > > Nor am I with some of the reactoin to the commit :-( > I'm sorry, but I fire back when people abuse me. Especially when it's a repeat offender who clearly didn't internalize the feedback given the first time. Warner