From owner-cvs-src@FreeBSD.ORG Sun Oct 26 23:15:09 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 259C116A4B3; Sun, 26 Oct 2003 23:15:09 -0800 (PST) Received: from is1.mh.itc.u-tokyo.ac.jp (is1.mh.itc.u-tokyo.ac.jp [133.11.205.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1F0543F3F; Sun, 26 Oct 2003 23:15:06 -0800 (PST) (envelope-from simokawa@sat.t.u-tokyo.ac.jp) Received: from is1.mh.itc.u-tokyo.ac.jp (is1.mh.itc.u-tokyo.ac.jp [127.0.0.1]) by is1.mh.itc.u-tokyo.ac.jp (Postfix) with ESMTP id 2F9B1218436; Mon, 27 Oct 2003 16:15:04 +0900 (JST) Received: from mailhosting.itc.u-tokyo.ac.jp (IDENT:mirapoint@mailhosting.itc.u-tokyo.ac.jp [133.11.205.3]) h9R7F3Su016141; Mon, 27 Oct 2003 16:15:03 +0900 Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp [133.11.135.3])3.3.5-GR) with ESMTP id ALE49489; Mon, 27 Oct 2003 16:15:02 +0900 (JST) Date: Mon, 27 Oct 2003 16:15:02 +0900 Message-ID: From: Hidetoshi Shimokawa To: "Kenneth D. Merry" In-Reply-To: <200310270615.h9R6FtQY038957@repoman.freebsd.org> References: <200310270615.h9R6FtQY038957@repoman.freebsd.org> User-Agent: Wanderlust/2.11.0 (Wonderwall) REMI/1.14.3 (Matsudai) FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.4 (patch 8) (Honest Recruiter) (i386--freebsd) X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7: #j7i14gu$jgR\S*&C3R/pJX List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2003 07:15:09 -0000 I have a similar problem with a da device too. It's a FireWire/compat flash adaptor(a removable da device). Though I forgot the detail, it takes too long time to probe if the media is not present. Do we have to patch scsi_da.c too? /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html At Sun, 26 Oct 2003 22:15:55 -0800 (PST), Kenneth D. Merry wrote: > > ken 2003/10/26 22:15:55 PST > > FreeBSD src repository > > Modified files: > sys/cam cam_periph.c > sys/cam/scsi scsi_cd.c > Log: > In camperiphdone(), make sure we check for fatal errors and bail out > instead of retrying them blindly. > > This should fix some of the problems people have been having with cdrom > drives taking a long time to probe. This should also eliminate the need > for the initial TUR in cdsize(). > > cam_periph.c: Don't keep retrying if the error we get back is a fatal > error. This should help us detect the transition from > "Logical unit not ready, cause not reportable" to "Medium > not present" in the "TUR many" handler. (The TUR many > handler gets triggered for Logical unit not ready, cause > not reportable errors.) > > scsi_cd.c: Remove the initial test unit ready in cdsize(). Hopefully > it isn't necessary after the above change. > > Submitted by: gibbs (mostly) > Tested by: peter > MFC After: 2 weeks > > Revision Changes Path > 1.55 +17 -2 src/sys/cam/cam_periph.c > 1.88 +0 -14 src/sys/cam/scsi/scsi_cd.c