Date: Sun, 15 May 2022 08:11:35 +0200 From: Stefan Esser <se@FreeBSD.org> To: Wen Heping <wen@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 0810a2380cc0 - main - www/joomla4: Add new port Message-ID: <8b59fa53-1bc1-f5cc-2a97-db42369f1bc3@FreeBSD.org> In-Reply-To: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> References: <202205150142.24F1gTG7047471@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------V9ho0POc1W0nqJG8xW1yLseP Content-Type: multipart/mixed; boundary="------------CIWLAz0Ndj5r02U8SSEOnJ1v"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: Wen Heping <wen@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Message-ID: <8b59fa53-1bc1-f5cc-2a97-db42369f1bc3@FreeBSD.org> Subject: Re: git: 0810a2380cc0 - main - www/joomla4: Add new port References: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> In-Reply-To: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> --------------CIWLAz0Ndj5r02U8SSEOnJ1v Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 15.05.22 um 03:42 schrieb Wen Heping: > www/joomla3: Add CONFLICTS [...] > +CONFLICTS=3D joomla-4.1.[0-9]* > www/joomla4: Add new port [...] > +CONFLICTS=3D joomla-3.10.[0-9]* Hi, please fix the CONFLICTS entries in both www/joomla3 and www/joomla4. These entries should only contain the PKGBASE of the conflicting package,= whenever possible. See https://docs.freebsd.org/en/books/porters-handbook/book/#conflicts The correct CONFLICTS definitions are: www/joomla3/Makefile: CONFLICTS=3D joomla www/joomla4/Makefile: CONFLICTS=3D joomla3 I have already fixed hundreds of wrong or stale CONFLICTS definitions (and there still are some 2500 in the ports tree, which I want to work on over the next few weeks), and your entries just add to that list. The entry in joomla3 is just wrong, since it will not match the PKGNAME of any joomla4 version. But both will get stale over time without being noticed in the ports system. And BTW: why has the PKGBASE of www/joomla4 been set to just "joomla", not "joomla4"? While version 4 may be supported for some time, there will probably be a joomla5 at some later date and then it would be good to have the names following a scheme that can be continued (i.e., joomla3, joomla4, joomla5) ... Regards, STefan --------------CIWLAz0Ndj5r02U8SSEOnJ1v-- --------------V9ho0POc1W0nqJG8xW1yLseP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmKAmZcFAwAAAAAACgkQR+u171r99USq uAgAyaGCwaabC5+Qk0Yijlp35SIW1zjVHHTMtyLyDELAGgTwclV3CSJm8FlRelNz0RjxpPiPcUJw Dp5JuPPvTbH2KlmN/b3biHV1krUFXPDAHWoKF79/g0r/TPrkywbTLIu4SlUCSvtsQmi79Wt2Reyq N0icZKqZFvcauRlFwLMIyRkTt4jDiGTJK74XcPE3Qicr2sK9xQPYBhjOBFEFcLipVFcSlVfNFpej mdopu6n5INL/3fUkOw/HuYkH1waVCgyY3VQf6YeruiSfKNGOEvwiZD3DH1xLLlGmuGqFtxKb88WS GHMMsi6KaOHWjpZiLfkzge3CO4oPDWpWAg8r6WhA+w== =IntL -----END PGP SIGNATURE----- --------------V9ho0POc1W0nqJG8xW1yLseP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8b59fa53-1bc1-f5cc-2a97-db42369f1bc3>