Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 May 2016 15:27:07 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        John Baldwin <jhb@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r299393 - in head: . share/mk
Message-ID:  <08cfa0ac-ad92-c8f9-2141-e72088b17d41@selasky.org>
In-Reply-To: <201605102232.u4AMWNvp000287@repo.freebsd.org>
References:  <201605102232.u4AMWNvp000287@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 05/11/16 00:32, John Baldwin wrote:
> Author: jhb
> Date: Tue May 10 22:32:23 2016
> New Revision: 299393
> URL: https://svnweb.freebsd.org/changeset/base/299393
>
> Log:
>   Change the default installation directory for modules to /boot/modules.
>
>   Kernel installs always override KMODDIR when installing modules, so
>   this default setting is only used for standalone module builds.  Many
>   out-of-tree modules manually override KMODDIR already to avoid placing
>   modules in /boot/kernel.  This now makes that behavior the default.
>
>   Discussed on:	arch@
>   Reviewed by:	imp
>   Relnotes:	yes
>
> Modified:
>   head/UPDATING
>   head/share/mk/bsd.own.mk
>
> Modified: head/UPDATING
> ==============================================================================
> --- head/UPDATING	Tue May 10 22:28:06 2016	(r299392)
> +++ head/UPDATING	Tue May 10 22:32:23 2016	(r299393)
> @@ -31,6 +31,14 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11
>  	disable the most expensive debugging functionality run
>  	"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
>
> +20160510:
> +	Kernel modules compiled outside of a kernel build now default to
> +	installing to /boot/modules instead of /boot/kernel.  Many kernel
> +	modules built this way (such as those in ports) already overrode
> +	KMODDIR explicitly to install into /boot/modules.  However,
> +	manually building and installing a module from /sys/modules will
> +	now install to /boot/modules instead of /boot/kernel.
> +
>  20160414:
>  	The CAM I/O scheduler has been committed to the kernel. There should be
>  	no user visible impact. This does enable NCQ Trim on ada SSDs. While the
>
> Modified: head/share/mk/bsd.own.mk
> ==============================================================================
> --- head/share/mk/bsd.own.mk	Tue May 10 22:28:06 2016	(r299392)
> +++ head/share/mk/bsd.own.mk	Tue May 10 22:32:23 2016	(r299393)
> @@ -165,11 +165,7 @@ BINGRP?=	wheel
>  BINMODE?=	555
>  NOBINMODE?=	444
>
> -.if defined(MODULES_WITH_WORLD)
>  KMODDIR?=	/boot/modules
> -.else
> -KMODDIR?=	/boot/kernel
> -.endif
>  KMODOWN?=	${BINOWN}
>  KMODGRP?=	${BINGRP}
>  KMODMODE?=	${BINMODE}
>

Just a small nit:

There is a comment in bsd.own.mk which needs updating too:

> #
> # KMODDIR       Base path for loadable kernel modules
> #               (see kld(4)). [/boot/kernel]

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?08cfa0ac-ad92-c8f9-2141-e72088b17d41>