Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Nov 2010 14:40:02 -0800
From:      Weongyo Jeong <weongyo.jeong@gmail.com>
To:        Hans Petter Selasky <hselasky@c2i.net>
Cc:        freebsd-usb@freebsd.org, Jung-uk Kim <jkim@freebsd.org>
Subject:   Re: [RFC] USBdump patches
Message-ID:  <20101123224002.GH92881@weongyo>
In-Reply-To: <201011232319.33678.hselasky@c2i.net>
References:  <AANLkTinaUNi3FGRiOkeTN2FKx3ybqE=F3W6%2BsV8qVCTf@mail.gmail.com> <AANLkTim15S-wOb-z2N7SHx2X%2Bty1qkdc3_Qz3q-PNsKY@mail.gmail.com> <20101123212448.GG92881@weongyo> <201011232319.33678.hselasky@c2i.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 23, 2010 at 11:19:33PM +0100, Hans Petter Selasky wrote:
> Hi,
> 
> Please find attached official usbdump patch from HPS trying to re-use as much 
> as possible of Weongyo's code which was committed not long ago. You need to 
> SVN up to the latest 9-current.
> 
> This patch should fix all USB-dump issues reported so far!
> 
> 1) Fix for proper offset calculation on ISOCHRONOUS reception.
> 2) Fixes for device mode.
> 3) PF-virtual-machine is OK (and done before copy of data).
> 4) Can load and unload the PF-code like a module.
> 
> How to use:
> 
> cd /usr/src
> cat usbdump_r215656_patch.txt | patch
> 
> You need to make new kernel, but not userland.
> 
> Install sys/dev/usb/usb_pf.h into /usr/include/dev/usb/ and make all install 
> in src/usr.sbin/usbdump .
> 
> After reboot:
> 
> kldload usb_pf
> 
> usbdump -d -1 -vvv
> 
> man usbdump

NACK.  You already could recognize that the patch is quite big and
multiple patches are mixed into one.  Please separate into smallest
pieces then send freebsd-usb@ again.  I don't want to do a jumbo jump.

regards,
Weongyo Jeong




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101123224002.GH92881>