From owner-svn-src-head@freebsd.org Sat Apr 15 02:36:55 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 985DED3EBBB; Sat, 15 Apr 2017 02:36:55 +0000 (UTC) (envelope-from peter@wemm.org) Received: from smtp2.wemm.org (smtp2.wemm.org [IPv6:2001:470:67:39d::78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp2.wemm.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 81FE63B0; Sat, 15 Apr 2017 02:36:55 +0000 (UTC) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (canning.wemm.org [192.203.228.65]) by smtp2.wemm.org (Postfix) with ESMTP id 4B8B94E7; Fri, 14 Apr 2017 19:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=m20140428; t=1492223815; bh=5h1T8H24HJ5mooEhKY2+WJVm9aCJPa9mIJnSn3W+RZw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tzmIBOOzOLLPn8Bw6HAzR871jTUyb+7IGjpykGhuJ71E87inF6DkPsO9OJi/lw/KE tsG7jicKQT0/SUqf9XFxqkaM1bytkaQF55Q8ahKNf8OGFm5snLhVKaSXmEetQycAQY NDuSdyjIfeyXXLfczeKsE63soqDVfbRDLSEy1Wms= From: Peter Wemm To: "Ngie Cooper (yaneurabeya)" Cc: Maxim Sobolev , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Hiren Panchasara , Hiroki Sato Subject: Re: svn commit: r316874 - head/sys/kern Date: Fri, 14 Apr 2017 19:36:55 -0700 Message-ID: <13691757.t3s7Qik7v1@overcee.wemm.org> User-Agent: KMail/4.14.10 (FreeBSD/12.0-CURRENT; KDE/4.14.10; amd64; ; ) In-Reply-To: References: <201704141723.v3EHNS3B043902@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3238559.iu6D6HdEu8"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Apr 2017 02:36:55 -0000 --nextPart3238559.iu6D6HdEu8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Friday, April 14, 2017 02:14:16 PM Ngie Cooper wrote: > > On Apr 14, 2017, at 14:10, Maxim Sobolev wr= ote: > >=20 > > Peter, Ngie, > >=20 > > Looks like out of that refactoring came a logical bug that is prese= nt in > > the head, which causes syslod to first to shutdown the socket for r= eading > > and then try to select/recv on it (which is somewhat stupid). And t= hat > > issue has been masked by shutdown() on datagram socket becoming > > effectively a NOP in 11 & head 20 months ago. It only affects head > > though, 11-stable still has the old code which does not include tha= t > > half-closed socket into the select list. Attached patch is expected= to > > fix head, Peter, it would be nice if you can give it a try (restori= ng > > latest changes into uipc_sockets.c) and let me know if it helps. > >=20 > > Thanks! >=20 > CCing hrs@ for input as he did the refactoring. > Thanks! > -Ngie >=20 > PS LGTM with the change. Will wait for feedback from wemm@. This is definitely not working. I get ENOSPC and listen queue overflo= ws on=20 /var/run/logpriv now. Grabbing an old 10.3 /usr/sbin/syslogd and placing it on the top of the= 12.x=20 one worked fine, aside from the include statements. =2D-=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI= 6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 --nextPart3238559.iu6D6HdEu8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEBgrA0Vr/vfNVuPoUNdaXCeyAngQFAljxh0cACgkQNdaXCeyA ngTMEAf/ZfGz2aGu0L9XPstos2TSqePLeyPsBf0RNANU3vhgbFcKQzLtIV0GXaKs rpadYtXEpunawlbe/vzz//BQU14Acf5v65YmMxjMS78ZEI2atalwAyZLLVKs2uRg ehTlq3mH0DaPi2E7Fd5BxdzNX3QsO6WC8cJ6QVKD4THNlCvYbyHANtBY31FUrKf1 a6UfWauFO1V0AVwhV6Ooj1SjRmGLpENSxFhs/dfieb6khE40V/aSnY7ngaGEBq8B eZZk/8p6K8gS4L1cBN/0BmVSCOkQvtD0jAdAJmbts2Qbk2hVGTjAsr+dr47jMPjG huf95KmoT3toCJvWLcQP3Iid/q/BmA== =HNXh -----END PGP SIGNATURE----- --nextPart3238559.iu6D6HdEu8--