From owner-freebsd-current@FreeBSD.ORG Thu Mar 25 03:04:59 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 978BA16A4D1 for ; Thu, 25 Mar 2004 03:04:59 -0800 (PST) Received: from darkness.comp.waw.pl (unknown [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB0B843D2F for ; Thu, 25 Mar 2004 03:04:58 -0800 (PST) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 50EF4ACAE3; Thu, 25 Mar 2004 12:04:57 +0100 (CET) Date: Thu, 25 Mar 2004 12:04:57 +0100 From: Pawel Jakub Dawidek To: Rafal Skoczylas Message-ID: <20040325110457.GX8930@darkness.comp.waw.pl> References: <20040323223020.GA2931@secprog.org> <20040324225318.GS8930@darkness.comp.waw.pl> <20040325103222.GA7210@secprog.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXjkYym6qfApNY5c" Content-Disposition: inline In-Reply-To: <20040325103222.GA7210@secprog.org> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: freebsd-current@freebsd.org Subject: Re: [UFS] Broken suiddir? (+patch) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2004 11:04:59 -0000 --BXjkYym6qfApNY5c Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 25, 2004 at 11:32:22AM +0100, Rafal Skoczylas wrote: +> On Wed, Mar 24, 2004 at 11:53:18PM +0100, Pawel Jakub Dawidek wrote: +> > +> - ucred.cr_uid =3D ip->i_uid; +> > +> + ucred.cr_uid =3D dp->i_uid; +> >=20 +> > I haven't test your report and patch yet, but it is strange. +> > In line 1403 stays: +> >=20 +> > ip->i_uid =3D dp->i_uid; +> >=20 +> > So ip->i_uid should be equal in line which you have patched. +>=20 +> Indeed, but somehow it wasn't. +> Hmm.. maybe I did some mistake when testing, but still this is +> quite strange as I asked a friend of mine to test it as well +> (on the same system tho) and we both had same results. +> Could anyone else try this? I've just tried and it works. Are you sure you have added +s bit on this directory? Even if there is no +s bit, group will be taken from parent directory for newly created file. Or maybe your file system isn't mounted with MNT_SUIDDIR flag? Try this: # mount -o suiddir /your_mount_point # chmod 4777 /your_mount_point/your_dir % touch /your_mount_point/your_dir/foo % ls -l /your_mount_point/your_dir/foo --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --BXjkYym6qfApNY5c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAYrzZForvXbEpPzQRAj1VAKC4tZRmcVFlZLXhwpJEiohsaTs0CwCgp9SA NYGxI1r1MhrTADZTjQPXOVE= =zeaJ -----END PGP SIGNATURE----- --BXjkYym6qfApNY5c--