Date: Wed, 18 Jul 2012 15:52:49 GMT From: Steven Hartland <steven.hartland@multiplay.co.uk> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/169974: Patch to add Quirks for SSD that are 4k optimised Message-ID: <201207181552.q6IFqnGF032508@red.freebsd.org> Resent-Message-ID: <201207181600.q6IG07Fx061488@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169974
>Category: kern
>Synopsis: Patch to add Quirks for SSD that are 4k optimised
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jul 18 16:00:07 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Steven Hartland
>Release: 8.3-RELEASE
>Organization:
Multiplay
>Environment:
FreeBSD build 8.3-RELEASE-p3 FreeBSD 8.3-RELEASE-p3 #3: Tue Jul 3 13:16:31 UTC 2012 root@build:/usr/obj/usr/src/sys/MULTIPLAY amd64
>Description:
Adds 4K quirks for the following SSD's which all perform better when 4K aligned
and only except 4K deletes (TRIM):-
* Corsair Force 2 & Force 3
* OCZ Agility 3
* OCZ Vertex 2 & Vertex 3
* SuperTalent TeraDrive CT
* Crucial RealSSD C300
* XceedIOPS SATA
* Intel 330 Series
* OCZ Deneva R Series
>How-To-Repeat:
N/A
>Fix:
Apply the attached patch
Patch attached with submission follows:
Adds 4K quirks for the following SSD's which all perform better when 4K aligned
and only except 4K deletes (TRIM):-
* Corsair Force 2 & Force 3
* OCZ Agility 3
* OCZ Vertex 2 & Vertex 3
* SuperTalent TeraDrive CT
* Crucial RealSSD C300
* XceedIOPS SATA
* Intel 330 Series
* OCZ Deneva R Series
--- ./sys/cam/scsi/scsi_da.c.orig 2012-07-13 18:54:45.525693438 +0000
+++ ./sys/cam/scsi/scsi_da.c 2012-07-13 18:55:06.959905372 +0000
@@ -807,6 +807,86 @@
{ T_DIRECT, SIP_MEDIA_FIXED, "WDC WD??", "???PVT*", "*" },
/*quirks*/DA_Q_4K
},
+ {
+ /*
+ * Corsair Force 2 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "Corsair CSSD-F*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * Corsair Force 3 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "Corsair Force 3*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * OCZ Agility 3 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "OCZ-AGILITY3*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * OCZ Vertex 2 SSDs (inc pro series)
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "OCZ?VERTEX2*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * OCZ Vertex 3 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "OCZ-VERTEX3*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * SuperTalent TeraDrive CT SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "FTM??CT25H*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * Crucial RealSSD C300 SSDs
+ * 4k optimised
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "C300-CTFDDAC???MAG*",
+ "*" }, /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * XceedIOPS SATA SSDs
+ * 4k optimised
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "SG9XCS2D*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * Intel 330 Series SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "INTEL SSDSC2ct*", "*" },
+ /*quirks*/DA_Q_4K
+ },
+ {
+ /*
+ * OCZ Deneva R Series SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "DENRSTE251M45*", "*" },
+ /*quirks*/DA_Q_4K
+ }
};
static disk_strategy_t dastrategy;
--- sys/cam/ata/ata_da.c 2012-07-13 16:41:49.838471171 +0000
+++ sys/cam/ata/ata_da.c 2012-07-18 12:14:49.189046166 +0000
@@ -268,6 +268,86 @@
/*quirks*/ADA_Q_4K
},
{
+ /*
+ * Corsair Force 2 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "Corsair CSSD-F*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * Corsair Force 3 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "Corsair Force 3*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * OCZ Agility 3 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ-AGILITY3*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * OCZ Vertex 2 SSDs (inc pro series)
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "OCZ?VERTEX2*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * OCZ Vertex 3 SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "OCZ-VERTEX3*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * SuperTalent TeraDrive CT SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "FTM??CT25H*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * Crucial RealSSD C300 SSDs
+ * 4k optimised
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "C300-CTFDDAC???MAG*",
+ "*" }, /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * XceedIOPS SATA SSDs
+ * 4k optimised
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "SG9XCS2D*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * Intel 330 Series SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "INTEL SSDSC2ct*", "*" },
+ /*quirks*/ADA_Q_4K
+ },
+ {
+ /*
+ * OCZ Deneva R Series SSDs
+ * 4k optimised & trim only works in 4k requests + 4k aligned
+ */
+ { T_DIRECT, SIP_MEDIA_FIXED, "*", "DENRSTE251M45*", "*" },
+ /*quirks*/ADA_Q_4K
+ }
+ {
/* Default */
{
T_ANY, SIP_MEDIA_REMOVABLE|SIP_MEDIA_FIXED,
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207181552.q6IFqnGF032508>