From owner-freebsd-ports-bugs  Fri Mar  7 17:40:10 2003
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 77CB337B401
	for <freebsd-ports-bugs@hub.freebsd.org>; Fri,  7 Mar 2003 17:40:08 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1ADA743F93
	for <freebsd-ports-bugs@hub.freebsd.org>; Fri,  7 Mar 2003 17:40:08 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h281e7NS026723
	for <freebsd-ports-bugs@freefall.freebsd.org>; Fri, 7 Mar 2003 17:40:07 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h281e7fS026721;
	Fri, 7 Mar 2003 17:40:07 -0800 (PST)
Date: Fri, 7 Mar 2003 17:40:07 -0800 (PST)
Message-Id: <200303080140.h281e7fS026721@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx>
Subject: Re: ports/49017: 'make deinstall' doesn't deinstall old version of
 ports
Reply-To: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx>
Sender: owner-freebsd-ports-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR ports/49017; it has been noted by GNATS.

From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx>
To: Sergey Matveychuk <sem@ciam.ru>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/49017: 'make deinstall' doesn't deinstall old version of
 ports
Date: Sat, 8 Mar 2003 02:30:00 +0100

 --=.04,Yx/qoK3Aa'k
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 
 Lately Sergey Matveychuk told:
 
 > --- bsd.port.mk.orig	Sun Mar  2 05:06:56 2003
 > +++ bsd.port.mk	Fri Mar  7 00:37:39 2003
 > @@ -3187,12 +3187,16 @@
 >  # Special target to remove installation
 >  
 >  .if !target(deinstall)
 > +deinstall_name!=${PKG_INFO} -q -O ${PKGORIGIN} 2> /dev/null || ${TRUE}
 > +.if ${deinstall_name} == ""
 > +deinstall_name=${PKGNAME}
 > +.endif
 
 it doesn't feel good to run pkg_info every time bsd.port.mk is used.
 how about:
 
 .if !target(deinstall)
 deinstall:
  	@deinstall_name=`${PKG_INFO} -q -O ${PKGORIGIN} 2> /dev/null`; \
 	${TEST} -z $${deinstall_name} && deinstall_name=${PKGNAME}; \
 	${ECHO_MSG} "===>  Deinstalling for ${PKGORIGIN} ($${deinstall_name})"; \
 	if ${PKG_INFO} -e $${deinstall_name}; then \
 		${PKG_DELETE} -f $${deinstall_name}; \
 	else \
 		${ECHO_MSG} "===>   ${PKGORIGIN} not installed, skipping"; \
 	fi
 	@${RM} -f ${INSTALL_COOKIE} ${PACKAGE_COOKIE}
 .endif
 
 -- 
 /"\   http://corecode.ath.cx/#donate
 \ /
  \     ASCII Ribbon Campaign
 / \  Against HTML Mail and News
 
 --=.04,Yx/qoK3Aa'k
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.1 (FreeBSD)
 
 iD8DBQE+aUebr5S+dk6z85oRAu7kAJ9tOqpszBgzPT4X8pPjCcpehbO/iACgzLqH
 0GoVcui+DKy78q3mzbZBGEg=
 =OOw1
 -----END PGP SIGNATURE-----
 
 --=.04,Yx/qoK3Aa'k--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports-bugs" in the body of the message