Date: Fri, 7 Mar 2003 17:40:07 -0800 (PST) From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/49017: 'make deinstall' doesn't deinstall old version of ports Message-ID: <200303080140.h281e7fS026721@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/49017; it has been noted by GNATS. From: "Simon 'portlint' Schubert" <corecode@corecode.ath.cx> To: Sergey Matveychuk <sem@ciam.ru> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/49017: 'make deinstall' doesn't deinstall old version of ports Date: Sat, 8 Mar 2003 02:30:00 +0100 --=.04,Yx/qoK3Aa'k Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Lately Sergey Matveychuk told: > --- bsd.port.mk.orig Sun Mar 2 05:06:56 2003 > +++ bsd.port.mk Fri Mar 7 00:37:39 2003 > @@ -3187,12 +3187,16 @@ > # Special target to remove installation > > .if !target(deinstall) > +deinstall_name!=${PKG_INFO} -q -O ${PKGORIGIN} 2> /dev/null || ${TRUE} > +.if ${deinstall_name} == "" > +deinstall_name=${PKGNAME} > +.endif it doesn't feel good to run pkg_info every time bsd.port.mk is used. how about: .if !target(deinstall) deinstall: @deinstall_name=`${PKG_INFO} -q -O ${PKGORIGIN} 2> /dev/null`; \ ${TEST} -z $${deinstall_name} && deinstall_name=${PKGNAME}; \ ${ECHO_MSG} "===> Deinstalling for ${PKGORIGIN} ($${deinstall_name})"; \ if ${PKG_INFO} -e $${deinstall_name}; then \ ${PKG_DELETE} -f $${deinstall_name}; \ else \ ${ECHO_MSG} "===> ${PKGORIGIN} not installed, skipping"; \ fi @${RM} -f ${INSTALL_COOKIE} ${PACKAGE_COOKIE} .endif -- /"\ http://corecode.ath.cx/#donate \ / \ ASCII Ribbon Campaign / \ Against HTML Mail and News --=.04,Yx/qoK3Aa'k Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+aUebr5S+dk6z85oRAu7kAJ9tOqpszBgzPT4X8pPjCcpehbO/iACgzLqH 0GoVcui+DKy78q3mzbZBGEg= =OOw1 -----END PGP SIGNATURE----- --=.04,Yx/qoK3Aa'k-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303080140.h281e7fS026721>