From owner-svn-src-head@FreeBSD.ORG Tue Dec 28 13:32:52 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C786A1065672; Tue, 28 Dec 2010 13:32:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 3755B8FC14; Tue, 28 Dec 2010 13:32:51 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id oBSDWmaa000712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Dec 2010 15:32:48 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id oBSDWmN1000469; Tue, 28 Dec 2010 15:32:48 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id oBSDWlWF000468; Tue, 28 Dec 2010 15:32:47 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 28 Dec 2010 15:32:47 +0200 From: Kostik Belousov To: Ulrich Sp??rlein Message-ID: <20101228133247.GR90883@deviant.kiev.zoral.com.ua> References: <201012250842.oBP8gchA016800@svn.freebsd.org> <20101228132942.GY23098@acme.spoerlein.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BZziOT8Kz25R/m/E" Content-Disposition: inline In-Reply-To: <20101228132942.GY23098@acme.spoerlein.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r216694 - head/libexec/rtld-elf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2010 13:32:52 -0000 --BZziOT8Kz25R/m/E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 28, 2010 at 02:29:43PM +0100, Ulrich Sp??rlein wrote: > On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Sat Dec 25 08:42:38 2010 > > New Revision: 216694 > > URL: http://svn.freebsd.org/changeset/base/216694 > >=20 > > Log: > > Add a hook to pass debug flags to the build of rtld when doing make in > > the rtld directory. > > =20 > > Reviewed by: kan >=20 > Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is > the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=3D-g is > working just fine for me. DEBUG_FLAGS=3D-g might be fine for you, but it does not do what rtld debugg= ing needs. Look at the -DDEBUG. If you want ${} instead of $(), feel free to change. >=20 > > Modified: > > head/libexec/rtld-elf/Makefile > >=20 > > Modified: head/libexec/rtld-elf/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/libexec/rtld-elf/Makefile Fri Dec 24 21:31:18 2010 (r216693) > > +++ head/libexec/rtld-elf/Makefile Sat Dec 25 08:42:38 2010 (r216694) > > @@ -34,7 +34,7 @@ CFLAGS+=3D -fPIC > > .else > > CFLAGS+=3D -fpic > > .endif > > -CFLAGS+=3D -DPIC > > +CFLAGS+=3D -DPIC $(DEBUG) > > LDFLAGS+=3D -shared -Wl,-Bsymbolic > > DPADD=3D ${LIBC_PIC} > > LDADD=3D -lc_pic -lssp_nonshared --BZziOT8Kz25R/m/E Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0Z5v8ACgkQC3+MBN1Mb4gOpQCeI2xsxpg1y8F3WmoQFMqEl8bu hw4AoIveWcjohTdkYeJtV1rZTDm8X4Uk =npGo -----END PGP SIGNATURE----- --BZziOT8Kz25R/m/E--