From owner-cvs-all Thu Jun 20 16: 2:31 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id 118C737B40B; Thu, 20 Jun 2002 16:00:34 -0700 (PDT) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020620230033.ZOBY11426.rwcrmhc51.attbi.com@InterJet.elischer.org>; Thu, 20 Jun 2002 23:00:33 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id PAA32994; Thu, 20 Jun 2002 15:58:11 -0700 (PDT) Date: Thu, 20 Jun 2002 15:58:10 -0700 (PDT) From: Julian Elischer To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mbuf.h In-Reply-To: <200206202129.g5KLTu577564@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Re: MFC.. I presume that this method will not explode binary drivers.. (i.e. alll normal data appears in the normal places in outgoing packets) On Thu, 20 Jun 2002, Luigi Rizzo wrote: > luigi 2002/06/20 14:29:56 PDT > > Modified files: > sys/sys mbuf.h > Log: > Add some #define's for mbuf annotations. > > As the comment in the code says, eventually there will be a proper > data structure (e.g NetBSD's struct m_tag) to store chains of > annotations, and mbuf-handling procedures will handle these chains > in the correct way. > > Right now, these chains do not exist, and we just use the constants > defined here to implement simple ad-hoc solutions to remove some global > variables used so far to pass around informations about packets > being processed. > > Global variables are not only ugly and make the code unreadable, they > also prevent from using parallelism in network stack processing. > > (the 3-days MFC only refers to this commit, i.e. the PACKET_TAG_* > constants; the full mechanism will be committed and MFC'ed on a > longer timescale). > > MFC after: 3 days > > Revision Changes Path > 1.91 +48 -0 src/sys/sys/mbuf.h > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message