From owner-freebsd-bugs@FreeBSD.ORG Mon Oct 24 09:10:01 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9426610656D3 for ; Mon, 24 Oct 2011 09:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6CF378FC1A for ; Mon, 24 Oct 2011 09:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9O9A1DI059044 for ; Mon, 24 Oct 2011 09:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9O9A1qv059043; Mon, 24 Oct 2011 09:10:01 GMT (envelope-from gnats) Resent-Date: Mon, 24 Oct 2011 09:10:01 GMT Resent-Message-Id: <201110240910.p9O9A1qv059043@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E4EB106566C for ; Mon, 24 Oct 2011 09:07:19 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 5D9748FC12 for ; Mon, 24 Oct 2011 09:07:19 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9O97Jns081458 for ; Mon, 24 Oct 2011 09:07:19 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p9O97JxF081457; Mon, 24 Oct 2011 09:07:19 GMT (envelope-from nobody) Message-Id: <201110240907.p9O97JxF081457@red.freebsd.org> Date: Mon, 24 Oct 2011 09:07:19 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/161958: Add keyword restrict to glob(). X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2011 09:10:01 -0000 >Number: 161958 >Category: misc >Synopsis: Add keyword restrict to glob(). >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 24 09:10:01 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: FreeBSD-current >Organization: >Environment: >Description: Add keyword restrict to glob(). >How-To-Repeat: >Fix: diff -u -r1.28 glob.c --- lib/libc/gen/glob.c 12 May 2010 17:44:00 -0000 1.28 +++ lib/libc/gen/glob.c 24 Oct 2011 06:33:08 -0000 @@ -163,7 +163,8 @@ #endif int -glob(const char *pattern, int flags, int (*errfunc)(const char *, int), glob_t *pglob) +glob(const char * __restrict pattern, int flags, + int (*errfunc)(const char *, int), glob_t * __restrict pglob) { const char *patnext; size_t limit; @@ -717,7 +718,7 @@ free(pglob->gl_pathv); pglob->gl_pathv = NULL; } - return(GLOB_NOSPACE); + return (GLOB_NOSPACE); } if (pglob->gl_pathv == NULL && pglob->gl_offs > 0) { =============================================================================== diff -u -r1.11 glob.h --- include/glob.h 16 Feb 2010 19:39:50 -0000 1.11 +++ include/glob.h 24 Oct 2011 05:48:35 -0000 @@ -98,7 +98,8 @@ #endif /* __BSD_VISIBLE */ __BEGIN_DECLS -int glob(const char *, int, int (*)(const char *, int), glob_t *); +int glob(const char * __restrict, int, + int (*)(const char *, int), glob_t * __restrict); void globfree(glob_t *); __END_DECLS ================================================================================ diff -u -r1.34 glob.3 --- lib/libc/gen/glob.3 15 Feb 2011 20:07:35 -0000 1.34 +++ lib/libc/gen/glob.3 24 Oct 2011 05:50:17 -0000 @@ -42,7 +42,7 @@ .Sh SYNOPSIS .In glob.h .Ft int -.Fn glob "const char *pattern" "int flags" "int (*errfunc)(const char *, int)" "glob_t *pglob" +.Fn glob "const char * restrict pattern" "int flags" "int (*errfunc)(const char *, int)" "glob_t * restrict pglob" .Ft void .Fn globfree "glob_t *pglob" .Sh DESCRIPTION Patch attached with submission follows: diff -u -r1.28 glob.c --- lib/libc/gen/glob.c 12 May 2010 17:44:00 -0000 1.28 +++ lib/libc/gen/glob.c 24 Oct 2011 06:33:08 -0000 @@ -163,7 +163,8 @@ #endif int -glob(const char *pattern, int flags, int (*errfunc)(const char *, int), glob_t *pglob) +glob(const char * __restrict pattern, int flags, + int (*errfunc)(const char *, int), glob_t * __restrict pglob) { const char *patnext; size_t limit; @@ -717,7 +718,7 @@ free(pglob->gl_pathv); pglob->gl_pathv = NULL; } - return(GLOB_NOSPACE); + return (GLOB_NOSPACE); } if (pglob->gl_pathv == NULL && pglob->gl_offs > 0) { =============================================================================== diff -u -r1.11 glob.h --- include/glob.h 16 Feb 2010 19:39:50 -0000 1.11 +++ include/glob.h 24 Oct 2011 05:48:35 -0000 @@ -98,7 +98,8 @@ #endif /* __BSD_VISIBLE */ __BEGIN_DECLS -int glob(const char *, int, int (*)(const char *, int), glob_t *); +int glob(const char * __restrict, int, + int (*)(const char *, int), glob_t * __restrict); void globfree(glob_t *); __END_DECLS ================================================================================ diff -u -r1.34 glob.3 --- lib/libc/gen/glob.3 15 Feb 2011 20:07:35 -0000 1.34 +++ lib/libc/gen/glob.3 24 Oct 2011 05:50:17 -0000 @@ -42,7 +42,7 @@ .Sh SYNOPSIS .In glob.h .Ft int -.Fn glob "const char *pattern" "int flags" "int (*errfunc)(const char *, int)" "glob_t *pglob" +.Fn glob "const char * restrict pattern" "int flags" "int (*errfunc)(const char *, int)" "glob_t * restrict pglob" .Ft void .Fn globfree "glob_t *pglob" .Sh DESCRIPTION >Release-Note: >Audit-Trail: >Unformatted: