Date: Wed, 13 Jul 2005 23:03:15 -0500 (CDT) From: Sean Farley <sean-freebsd@farley.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: nobutaka@FreeBSD.org Subject: ports/83430: [PATCH] devel/boehm-gc: Fix WITH_* knobs when BATCH is defined Message-ID: <200507140403.j6E43F6f056984@thor.farley.org> Resent-Message-ID: <200507140410.j6E4AFMk089486@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 83430
>Category: ports
>Synopsis: [PATCH] devel/boehm-gc: Fix WITH_* knobs when BATCH is defined
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 14 04:10:15 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Sean Farley
>Release: FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD thor.farley.org 5.4-STABLE FreeBSD 5.4-STABLE #0: Thu Jun 23 09:55:25 CDT 2005
>Description:
Testing WITH_XYZ and WITHOUT_XYZ will always return false in batch mode.
I think the convention is to test for the existance of the variable that
is opposite of what is in the OPTIONS variable.
Run 'make rmconfig' before trying the following:
'make -DWITH_THREADING -DBATCH -V PKGNAME' will return boehm-gc-6.5
before and boehm-gc+threaded-6.5 after the change.
Port maintainer (nobutaka@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:
--- boehm-gc-6.5.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/devel/boehm-gc.orig/Makefile /usr/ports/devel/boehm-gc/Makefile
--- /usr/ports/devel/boehm-gc.orig/Makefile Wed Jul 13 22:52:13 2005
+++ /usr/ports/devel/boehm-gc/Makefile Wed Jul 13 22:55:55 2005
@@ -27,9 +27,9 @@
.include <bsd.port.pre.mk>
-.if defined(WITH_THREADING) && !defined(WITHOUT_THREADING)
+.if defined(WITH_THREADING)
CONFIGURE_ARGS+= --enable-threads=posix --enable-thread-local-alloc
-.if defined(WITH_PARALLEL_MARK) && !defined(WITHOUT_PARALLEL_MARK)
+.if defined(WITH_PARALLEL_MARK)
CONFIGURE_ARGS+= --enable-parallel-mark
.endif
PKGNAMESUFFIX= +threaded
@@ -37,11 +37,11 @@
CONFIGURE_ARGS+= --disable-threads
PKGNAMESUFFIX= # empty
.endif
-.if defined(WITH_REDIRECT) && !defined(WITHOUT_REDIRECT)
+.if defined(WITH_REDIRECT)
CONFIGURE_ARGS+= --enable-redirect-malloc
PKGNAMESUFFIX:= ${PKGNAMESUFFIX}+redirect
.endif
-.if defined(WITH_FULLDEBUG) && !defined(WITHOUT_FULLDEBUG)
+.if defined(WITH_FULLDEBUG)
CONFIGURE_ARGS+= --enable-full-debug
PKGNAMESUFFIX:= ${PKGNAMESUFFIX}+fulldebug
.endif
--- boehm-gc-6.5.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507140403.j6E43F6f056984>