From owner-svn-src-all@freebsd.org Wed Dec 16 15:08:54 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C1E2A49AFF for ; Wed, 16 Dec 2015 15:08:54 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com [IPv6:2607:f8b0:400e:c00::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B60F18DA for ; Wed, 16 Dec 2015 15:08:54 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf0-x236.google.com with SMTP id e66so13873863pfe.0 for ; Wed, 16 Dec 2015 07:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=tc+2PmISkM2qJYJKtcraU/URwndZ/OEzhrhXs4vMJ1Q=; b=EMzBzQkxAEPaG7PuX7B76j27U4BeRnNse/U4CY+6E6xFge3ri+icsDEaTMqtyF17b7 wsmyWsRQAAqFqpy30GHJqcmMe7xIRVOHRH7HSyc1fQLnktCPP6T+QckfWzVtM5H/FFlI /rpTnMN79H2Zs9TFhGZMkIR6yoVx9Pw2qc50E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=tc+2PmISkM2qJYJKtcraU/URwndZ/OEzhrhXs4vMJ1Q=; b=aUV7f1p8vXex25i6beYem+Y19xjOdPWmVC4mxw/DGr02yNrWTfthLfyLHkYAyfcGRL Uz9yuvG/ljG9kNi0velNmBhdC6briITxkAGOpU/AlS/h5L24Yd44yHGactZz80I5LiUo 2yN8xhpdQIB3NiWOMM/ptjZBbS/mxIb7D3JHUozEJfwJZCw3ixVbjc6lBtykqpc78iGY GGNIHgAxWfriGxv7WlaExYkN3so06Tg4KSKnjeiwHMnymlFFfyzpqOCqL1Iax7tKxei3 uwe/k/RLOKdeSwMuIqg8q8C6WjVnSMVVXYrjt6uWuYeLcgEq1Wu3oPBXjodXmtrg0W+l dRkw== X-Gm-Message-State: ALoCoQl32BcthSWXxwxNzApGRjH7WG3k5OnDL1pmNAnkYJl3DC+dPPojhRPO6biGfhn6GrKYYgpfR04FG4MQ9idpOK6/6pKiag== X-Received: by 10.98.73.19 with SMTP id w19mr1845556pfa.103.1450278533744; Wed, 16 Dec 2015 07:08:53 -0800 (PST) Received: from [10.0.104.77] (173-164-135-226-SFBA.hfc.comcastbusiness.net. [173.164.135.226]) by smtp.gmail.com with ESMTPSA id 7sm5523938pfb.62.2015.12.16.07.08.51 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 07:08:52 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r292309 - in head/sys: modules modules/tcp modules/tcp/fastpath netinet netinet/tcp_stacks From: Randall Stewart In-Reply-To: Date: Wed, 16 Dec 2015 07:08:49 -0800 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <1A3645F3-3287-4CD8-B69D-AC053507D435@netflix.com> References: <201512160056.tBG0ujqA067178@repo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 15:08:54 -0000 Ahh I think I see this is a difference between our friend clang and gcc.. since I bet ppc uses gcc not clang :-o I will have something for you in a sec.. sorry about that Ed R This is the difference between=20 On Dec 16, 2015, at 6:00 AM, Ed Maste wrote: > On 16 December 2015 at 00:56, Randall Stewart wrote: >> Author: rrs >> Date: Wed Dec 16 00:56:45 2015 >> New Revision: 292309 >> URL: https://svnweb.freebsd.org/changeset/base/292309 >>=20 >> Log: >> First cut of the modularization of our TCP stack. Still >> to do is to clean up the timer handling using the async-drain. >> Other optimizations may be coming to go with this. Whats here >> will allow differnet tcp implementations (one included). >> Reviewed by: jtl, hiren, transports >> Sponsored by: Netflix Inc. >> Differential Revision: D4055 >=20 > This broke at least powerpc builds: >=20 > = /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_= stacks/fastpath.c:148: > warning: redundant redeclaration of 'tcp_dooptions' > [-Wredundant-decls] > /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:736: warning: > previous declaration of 'tcp_dooptions' was here > = /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_= stacks/fastpath.c:150: > warning: redundant redeclaration of 'tcp_dropwithreset' > [-Wredundant-decls] > /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:738: warning: > previous declaration of 'tcp_dropwithreset' was here > = /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_= stacks/fastpath.c:152: > warning: redundant redeclaration of 'tcp_pulloutofband' > [-Wredundant-decls] > /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:740: warning: > previous declaration of 'tcp_pulloutofband' was here > = /scratch/tmp/emaste/freebsd/sys/modules/tcp/fastpath/../../../netinet/tcp_= stacks/fastpath.c:153: > warning: redundant redeclaration of 'tcp_xmit_timer' > [-Wredundant-decls] > /scratch/tmp/emaste/freebsd/sys/netinet/tcp_var.h:741: warning: > previous declaration of 'tcp_xmit_timer' was here > ... -------- Randall Stewart rrs@netflix.com 803-317-4952