From owner-svn-src-all@FreeBSD.ORG  Tue Nov  4 20:43:16 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 1A417AA7;
 Tue,  4 Nov 2014 20:43:16 +0000 (UTC)
Message-ID: <54593A63.70100@FreeBSD.org>
Date: Tue, 04 Nov 2014 15:43:15 -0500
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Dmitry Morozovsky <marck@rinet.ru>
Subject: Re: svn commit: r274095 - head/release
References: <201411041724.sA4HOEGD098532@svn.freebsd.org>
 <alpine.BSF.2.00.1411042244180.47840@woozle.rinet.ru>
 <5459340D.2030605@FreeBSD.org>
 <alpine.BSF.2.00.1411042320490.47840@woozle.rinet.ru>
In-Reply-To: <alpine.BSF.2.00.1411042320490.47840@woozle.rinet.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: svn-src-head@freebsd.org, Glen Barber <gjb@freebsd.org>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Nov 2014 20:43:16 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/04/2014 15:24, Dmitry Morozovsky wrote:
> On Tue, 4 Nov 2014, Jung-uk Kim wrote:
> 
>>>> Log: Fix VOLUME_LABEL when BRANCH contains non-alpha
>>>> characters, in particular '-' and '.'.
>>> 
>>> [snip]
>>> 
>>> By the way, what are original reasons to not allow '-' and '_'
>>> in volume names?
>>> 
>>> It looks a bit inconsistent with other file systems volume 
>>> labels...
>> 
>> AFAIK, it is an ISO9660 limitation, i.e., it must be
>> "d-characters".
>> 
>> http://wiki.osdev.org/ISO_9660#String_format 
>> http://wiki.osdev.org/ISO_9660#The_Primary_Volume_Descriptor
>> 
>> In fact, makefs(8) enforces this rule.
> 
> Ah, so iso9660 has stricter rules than, say, xFAT/NTFS and even
> UFS...
> 
> Maybe then we could distinguish file system type given to makefs(8)
> and apply different check/sed rules depending on it?
> 
> I mean: it looks a bit unexpected (if not uncomfortable) to have
> label set up by outer OS accepted by geom_label (and thus created
> in /dev tree) but unable to duplicate it via makefs(8) and similar
> mechanisms...

Our mount_cd9660(8) allows it because there are broken CDs in real world.

http://wiki.osdev.org/ISO_9660#String_format

"Note that not all CDs strictly adhere to the character sets specified
in ISO 9660."

Actually, popular tools, e.g., mkisofs, do not do strict format checking.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJUWTpjAAoJEHyflib82/FGd3sH+gKDR+7ZyHwZoX2rnfbiweKo
8uYYe50RyNfGvbwztuf6GVl1pP8U3JT3sctTvlDi5teoy2O1LNnFdQucoP0eYMDk
QrybHBoMhsRL8QfnW2VT6NkwjRbojJ39XdItN4Nm4uZXPSG5oI8DjXygwYeEhDXL
Vt+pWf7pHNChcQRjaufoMLCuyWoAWatcJi0tt5DXkwp986E1+B7T9MQLYVzNsTYO
m7b5Byxz9Wxqbax3+pxI8zp6pnaWRgICBvyaDGGCKlsYK5YzRNz2iria4O79oUQT
4eclRZBDnSZNmNnefQhTCA9aTwt4et95bn9ZZfkCE9X83PBRTxmZATtXyhKzRU4=
=cvyS
-----END PGP SIGNATURE-----