From owner-freebsd-gecko@FreeBSD.ORG  Tue Jul 21 11:28:51 2009
Return-Path: <owner-freebsd-gecko@FreeBSD.ORG>
Delivered-To: gecko@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0A7A9106564A
	for <gecko@FreeBSD.org>; Tue, 21 Jul 2009 11:28:51 +0000 (UTC)
	(envelope-from ale@FreeBSD.org)
Received: from andxor.it (relay.andxor.it [195.223.2.3])
	by mx1.freebsd.org (Postfix) with SMTP id 4237B8FC13
	for <gecko@FreeBSD.org>; Tue, 21 Jul 2009 11:28:49 +0000 (UTC)
	(envelope-from ale@FreeBSD.org)
Received: (qmail 25975 invoked from network); 21 Jul 2009 11:02:08 -0000
Received: from unknown (HELO ale.andxor.it) (192.168.2.5)
	by andxor.it with SMTP; 21 Jul 2009 11:02:08 -0000
Message-ID: <4A65A030.8030701@FreeBSD.org>
Date: Tue, 21 Jul 2009 13:02:08 +0200
From: Alex Dupre <ale@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.22 (X11/20090624)
MIME-Version: 1.0
To: gecko@FreeBSD.org
References: <200907210929.n6L9TDU5013696@repoman.freebsd.org>
	<20090721094900.4EE9C39843@qat.tcbug.org>
In-Reply-To: <20090721094900.4EE9C39843@qat.tcbug.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Martin Wilke <miwi@FreeBSD.org>
Subject: CPU_ARCH not set on amd64
X-BeenThere: freebsd-gecko@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Gecko Rendering Engine issues <freebsd-gecko.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gecko>
List-Post: <mailto:freebsd-gecko@freebsd.org>
List-Help: <mailto:freebsd-gecko-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
	<mailto:freebsd-gecko-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jul 2009 11:28:51 -0000

The latest update of enigmail broke builds on amd64 platform. I could
fix it in the enigmail port, but I think it's an issue in the mozilla
ports on FreeBSD. Every mozilla's configure has the following sections:

=====================================================================
# Only set CPU_ARCH if we recognize the value of OS_TEST

case "$OS_TEST" in
*86 | i86pc)
    CPU_ARCH=x86
    ;;

...

x86_64 | sparc | ppc | ia64)
    CPU_ARCH="$OS_TEST"
    ;;
esac

...

if test -n "${CPU_ARCH}" -a -n "${TARGET_COMPILER_ABI}"; then
    TARGET_XPCOM_ABI="${CPU_ARCH}-${TARGET_COMPILER_ABI}"
fi
=====================================================================

So, on amd64, the CPU_ARCH variable is not set, and so neither
TARGET_XPCOM_ABI. The new enigmail Makefile doesn't correctly check for
an empty TARGET_XPCOM_ABI variable, but probably the right thing to do
is add "amd64" to the last switch case, since "amd64" should be
recognized on FreeBSD platform. Opinions?

P.S.: I've not tested the proposed patch, I looked only at the configure
code.

-- 
Alex Dupre