From owner-cvs-all@FreeBSD.ORG Wed Oct 26 22:47:28 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF5E216A41F; Wed, 26 Oct 2005 22:47:28 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13E0C43D45; Wed, 26 Oct 2005 22:47:21 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9QMlDOx016223; Wed, 26 Oct 2005 15:47:13 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9QMlC25016222; Wed, 26 Oct 2005 15:47:12 -0700 (PDT) (envelope-from obrien) Date: Wed, 26 Oct 2005 15:47:12 -0700 From: "David O'Brien" To: Roman Kurakin Message-ID: <20051026224712.GA16118@dragon.NUXI.org> References: <200509271657.j8RGvj2n015326@repoman.freebsd.org> <20051024072423.GA34909@dragon.NUXI.org> <200510241034.27073.jhb@freebsd.org> <20051025052018.GE55418@dragon.NUXI.org> <435E04AA.3080605@cronyx.ru> <20051026172734.GA99901@dragon.NUXI.org> <435FE099.6060508@cronyx.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <435FE099.6060508@cronyx.ru> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: Roman Kurakin , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/dev/cp if_cp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2005 22:47:29 -0000 On Thu, Oct 27, 2005 at 12:01:29AM +0400, Roman Kurakin wrote: > David O'Brien: > >On Tue, Oct 25, 2005 at 02:10:50PM +0400, Roman Kurakin wrote: > >>The commit log didn't state what was the problem variable forward > >>declaration or/and function > >>forward declaration. > > > >Since you became a committer 2003/12/18, I guess you haven't been part of > >FreeBSD when we've worked on a GCC compiler upgrade. We make these type > >of changes to make a new version of GCC build FreeBSD. The other choice > >is to disconnect these drivers from the build. The commits done where > >typical of what's been done for the past decade. > > > Please provide detailed technical information what is wrong in my > change of your commit. Instead of arguing this with you as it is probably fruitless. If you're going to pull the "maintainer" card, then please have these drivers moved to src/sys/contrib and note them in src/MAINTAINERS. That way this isn't a landmine for other committers to step on. > I do not want to list them in src/MAINTAINERS cause I think it is > better to allow any commits. > Cases such this one is rare. Rare or not, they can occur so why not take easy steps to avoid strife? -- -- David (obrien@FreeBSD.org)