From owner-freebsd-pf@FreeBSD.ORG Thu Sep 16 04:02:12 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 674) id E80EB16A4CF; Thu, 16 Sep 2004 04:02:12 +0000 (GMT) Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 38095 invoked by uid 1005); 24 Feb 2004 01:34:26 -0000 Delivered-To: max@vampire.homelinux.org Received: (qmail 38092 invoked from network); 24 Feb 2004 01:34:25 -0000 Received: from moutng.kundenserver.de (212.227.126.187) by p50839aba.dip.t-dialin.net with SMTP; 24 Feb 2004 01:34:25 -0000 Received: from [212.227.126.212] (helo=mxng16.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1AvROi-0004C7-00 for max@vampire.homelinux.org; Tue, 24 Feb 2004 02:30:08 +0100 Received: from [206.53.239.180] (helo=turing.freelists.org) by mxng16.kundenserver.de with esmtp (Exim 3.35 #1) id 1AvROi-0003ri-00 for max@love2party.net; Tue, 24 Feb 2004 02:30:08 +0100 Received: from turing (localhost [127.0.0.1])ESMTP id 82991394F97; Mon, 23 Feb 2004 20:27:32 -0500 (EST) Received: with ECARTIS (v1.0.0; list pf4freebsd); Mon, 23 Feb 2004 20:27:20 -0500 (EST) X-Original-To: pf4freebsd@freelists.org Delivered-To: pf4freebsd@freelists.org Received: from smtp.fud.org.nz (203-79-110-29.cable.paradise.net.nz [203.79.110.29])ESMTP id E758D394EED for ; Mon, 23 Feb 2004 20:27:17 -0500 (EST) Received: by smtp.fud.org.nz (Postfix, from userid 1001) id C7D00170DF; Tue, 24 Feb 2004 14:29:47 +1300 (NZDT) From: Andrew Thompson To: pf4freebsd@freelists.org Message-ID: <20040224012947.GA99698@kate.fud.org.nz> References: <20040224001503.GA99464@kate.fud.org.nz> <200402240135.55752.max@love2party.net> Mime-Version: 1.0 Content-type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200402240135.55752.max@love2party.net> User-Agent: Mutt/1.5.6i X-archive-position: 283 X-ecartis-version: Ecartis v1.0.0 Sender: pf4freebsd-bounce@freelists.org Errors-To: pf4freebsd-bounce@freelists.org X-original-sender: andy@fud.org.nz Precedence: normal X-list: pf4freebsd Content-Transfer-Encoding: quoted-printable X-Provags-Forward: max@love2party.net -> max@vampire.homelinux.org X-UID: 401 X-Length: 3365 X-Mailman-Approved-At: Thu, 16 Sep 2004 04:04:43 +0000 Subject: [pf4freebsd] Re: pfflowd port X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Reply-To: pf4freebsd@freelists.org List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 16 Sep 2004 04:02:13 -0000 X-Original-Date: Tue, 24 Feb 2004 14:29:47 +1300 X-List-Received-Date: Thu, 16 Sep 2004 04:02:13 -0000 On Tue, Feb 24, 2004 at 01:35:55AM +0100, Max Laier wrote: > On Tuesday 24 February 2004 01:15, Andrew Thompson wrote: > > Hi all, > > > > I have created a port for pfflowd and thought i'd get feedback before > > submitting a PR. > > > > It can be found @ > > > > http://www.fud.org.nz/pfflowd-port.tar.gz >=20 > Okay, some feedback: > 1) You copied from security/pf (which is okay), but you should update t= he=20 > pkg-descr. oops, my bad. > 2) pkg-plist is empty, but should contain: > sbin/pfflowd > etc/rc.d/pfflowd.sh.sample oops again :) > 3) Not sure what the patch for pfflowd.c should do. What is wrong with = the=20 > check for invalid ports? It generated a gcc warning, as addr->sin_port is a uint16_t which cant be negative or >65536. -Werror made this fatal. > 4) Maybe get the pidfile.{c,h} from us (include/support/) and add them=20 > instead of just removing and pidfile support. Thanks, I wasnt sure where pidfile() came from. Andy